Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Include "exports" resolver specification #28899

Closed
wants to merge 5 commits into from

Conversation

guybedford
Copy link
Contributor

This amends the ES module resolver specification in the documentation to include the behaviour of the "exports" feature as implemented and merged in #28568.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 30, 2019
@guybedford guybedford requested a review from jkrems July 30, 2019 00:33
Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit about the non-object edge case. Other LGTM.

doc/api/esm.md Outdated Show resolved Hide resolved
doc/api/esm.md Outdated Show resolved Hide resolved
doc/api/esm.md Outdated Show resolved Hide resolved
@guybedford
Copy link
Contributor Author

@jkrems I believe I've adjusted it to the implementation now, thanks.

@Trott
Copy link
Member

Trott commented Aug 1, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3817/ (scheduled--Jenkins is going down but presumably the CI job will kick off when it's back up)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 1, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 1, 2019
PR-URL: nodejs#28899
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 1, 2019

Landed in 8492acf

@Trott Trott closed this Aug 1, 2019
targos pushed a commit that referenced this pull request Aug 2, 2019
PR-URL: #28899
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants