modules: missing exports as MODULE_NOT_FOUND #28905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
//cc @nodejs/modules-active-members |
guybedford
changed the title
|
Corrected - it seems I've used the words "not valid exports" here in the title and initial paragraph, when I really meant "missing export". |
ljharb
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
This is a really important change particularly because it should not be possible to know if a path does not exist, or "exists but exports denies you access to it". I consider this a security property as well as something that if unmerged, would constitute an observable breaking change to add a non-exported file.
Trott
approved these changes
Jul 31, 2019
cjihrig
approved these changes
Jul 31, 2019
jkrems
approved these changes
Jul 31, 2019
jkrems
added
the
author ready
lpinca
approved these changes
Jul 31, 2019
trivikr
approved these changes
Jul 31, 2019
|
Landed in 452b393 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 2, 2019
PR-URL: nodejs#28905 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
PR-URL: #28905 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems I missed this change when reviewing #28759, where previously the package.json
"exports"would throw aMODULE_NOT_FOUNDerror if trying to import something from a package that was a missing export (changed on this line here - https://github.com/nodejs/node/pull/28759/files#diff-4a5950be44f56dfca2e7fa3c4e1fc0e4).I think it is quite important for the core resolver to have a unified
MODULE_NOT_FOUNDerror instead of splitting this off into different cases, as any tool that uses a resolver typically wants to be able to filter these errors specifically, and having many variations of not found error codes will not help that.Just like the package.json "main" not being found is still a
MODULE_NOT_FOUNDerror and not aMAIN_NOT_FOUND, I think we should ensure missing"exports"are still aMODULE_NOT_FOUNDerror.This implements that approach for both the CJS and ESM resolvers.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes