Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: shallow copy option when create Server #28924

Closed
wants to merge 1 commit into from
Closed

net: shallow copy option when create Server #28924

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

@himself65 himself65 commented Aug 1, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Aug 1, 2019
ChALkeR
ChALkeR reviewed Aug 1, 2019
View reviewed changes
lib/net.js Outdated Show resolved Hide resolved
@himself65 himself65 force-pushed the refactor-net-Server branch from 3f733a4 to 96f27db Compare August 1, 2019 15:04
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24838/

@Trott
Copy link
Member

Trott commented Aug 4, 2019

Landed in d530354

@Trott Trott closed this Aug 4, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 4, 2019
@himself65 @Trott
net: shallow copy option when create Server
d530354 
PR-URL: nodejs#28924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit that referenced this pull request Aug 6, 2019
@himself65 @BridgeAR
net: shallow copy option when create Server
3c52dbe 
PR-URL: #28924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shisama shisama shisama approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@himself65 @nodejs-github-bot @Trott @ChALkeR @jasnell @addaleax @lpinca @cjihrig @shisama