Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify when destroy emits events #28970

Closed
wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 5, 2019

Surprisingly this can be quite relevant when working with destroy.

Grammar fix.

Checklist
  • documentation is changed or added

Sorry, something went wrong.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Aug 5, 2019
@ronag ronag changed the title docs: clarify when destroy emits events doc: clarify when destroy emits events Aug 5, 2019
@ronag ronag force-pushed the doc-clarify-destroy-events branch from dfe2006 to ec68dd8 Compare August 5, 2019 10:02
This was referenced Aug 6, 2019
doc/api/stream.md Outdated Show resolved Hide resolved
doc/api/stream.md Outdated Show resolved Hide resolved
@ronag ronag force-pushed the doc-clarify-destroy-events branch 2 times, most recently from 2b38e1b to 02fe331 Compare August 8, 2019 11:10
doc/api/stream.md Outdated Show resolved Hide resolved
doc/api/stream.md Outdated Show resolved Hide resolved
@ronag ronag force-pushed the doc-clarify-destroy-events branch from 02fe331 to cb3db82 Compare August 11, 2019 20:19
@ronag
Copy link
Member Author

ronag commented Sep 18, 2019

@Trott: this is just grammar fixes at this point

@Trott
Copy link
Member

Trott commented Sep 21, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2019
@Trott
Copy link
Member

Trott commented Sep 22, 2019

Landed in 1fceccb

@Trott Trott closed this Sep 22, 2019
Trott pushed a commit that referenced this pull request Sep 22, 2019

Verified

This commit was signed with the committer’s verified signature.
jasnell James M Snell
PR-URL: #28970
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Sep 23, 2019

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
PR-URL: #28970
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
PR-URL: #28970
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants