stream: improve read() performance further #29077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
stream
addaleax
approved these changes
Aug 10, 2019
Trott
approved these changes
Aug 10, 2019
ZYSzys
approved these changes
Aug 10, 2019
cjihrig
approved these changes
Aug 10, 2019
lpinca
reviewed
Aug 11, 2019
lib/internal/streams/buffer_list.js
Outdated
| const slice = data.slice(0, n); | ||
| this.head.data = data.slice(n); | ||
| return slice; | ||
| } else if (n === data.length) { |
There was a problem hiding this comment.
Suggested change
| } else if (n === data.length) { | |
| } | |
| if (n === data.length) { |
There is a return statement in the previous if branch so I wonder if we can remove the else branch.
mscdex
force-pushed
the
streams-readable-perf3
branch
from
0597bda to
793ad82
Compare
lpinca
approved these changes
Aug 11, 2019
|
Landed in 382f84a |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 12, 2019
PR-URL: nodejs#29077 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
PR-URL: #29077 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Aug 20, 2019
This was referenced Jan 19, 2021
This was referenced Jan 20, 2021
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes