stream: optimize creation #29135
Closed
stream: optimize creation #29135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
|
@nodejs/streams |
mscdex
reviewed
Sep 12, 2019
mscdex
reviewed
Sep 12, 2019
lib/_stream_readable.js
Outdated
| // However, some cases require setting options to different | ||
| // values for the readable and the writable sides of the duplex stream. | ||
| // These options can be provided separately as readableXXX and writableXXX. | ||
| function ReadableState(options, isDuplex) { |
There was a problem hiding this comment.
missing the stream parameter
ronag
force-pushed
the
stream-creation
branch
3 times, most recently
from
e160d2a to
7ce2ad9
Compare
|
This apparently needs a rebase in order to run benchmarks in CI. |
ronag
force-pushed
the
stream-creation
branch
from
7ce2ad9 to
e432835
Compare
|
rebased |
ZYSzys
approved these changes
Sep 15, 2019
|
@mscdex: Another try at Benchmark CI? |
|
Benchmark results from CI: 19:26:09 confidence improvement accuracy (*) (**) (***)
19:26:09 streams/creation.js kind='duplex' n=50000000 *** 16.85 % ±2.12% ±2.82% ±3.67%
19:26:09 streams/creation.js kind='readable' n=50000000 1.41 % ±1.82% ±2.43% ±3.16%
19:26:09 streams/creation.js kind='transform' n=50000000 *** 9.88 % ±1.71% ±2.28% ±2.96%
19:26:09 streams/creation.js kind='writable' n=50000000 ** -3.08 % ±1.95% ±2.60% ±3.38%
19:26:09 Seems good to me, but posting here in case anyone thinks the one slightly slower benchmark result is critical. (I imagine we're more interested in the two positive results that are both more statistically significant and larger in magnitude.) |
Trott
added
the
author ready
ZYSzys
pushed a commit
that referenced
this pull request
Sep 22, 2019
PR-URL: #29135 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
|
Landed in bd02775. |
targos
pushed a commit
that referenced
this pull request
Sep 23, 2019
PR-URL: #29135 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
PR-URL: #29135 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Sep 25, 2019
This was referenced Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize stream creation.
Takes the non-controversial parts of #29127.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes