Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: support closing dumb terminals #29149

Merged
merged 2 commits into from
Aug 17, 2019
Merged

readline: support closing dumb terminals #29149

merged 2 commits into from
Aug 17, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 15, 2019

Fixes: #29111

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Aug 15, 2019
bnoordhuis
bnoordhuis approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to test ^C as well but LGTM either way.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25053/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 17, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/25054/

EDIT: CI was green.

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 17, 2019
@cjihrig
readline: close dumb terminals on Control+C
a5edcee 
This commit adds support for closing a readline interface
on Control+C when the terminal is dumb.

PR-URL: nodejs#29149
Fixes: nodejs#29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig
readline: close dumb terminals on Control+D
93b341e 
This commit adds support for closing a readline interface
on Control+D when the terminal is dumb.

PR-URL: nodejs#29149
Fixes: nodejs#29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig merged commit 93b341e into nodejs:master Aug 17, 2019
@cjihrig cjihrig deleted the dumb branch August 17, 2019 19:53
targos pushed a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
readline: close dumb terminals on Control+C
3c346b8 
This commit adds support for closing a readline interface
on Control+C when the terminal is dumb.

PR-URL: #29149
Fixes: #29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
readline: close dumb terminals on Control+D
7f11c72 
This commit adds support for closing a readline interface
on Control+D when the terminal is dumb.

PR-URL: #29149
Fixes: #29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to exit REPL via escape codes when TERM=dumb
5 participants
@cjihrig @nodejs-github-bot @bnoordhuis @jasnell @lpinca