Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix Buffer OOM error message #2915

Closed
wants to merge 1 commit into from
Closed

test: fix Buffer OOM error message #2915

wants to merge 1 commit into from

Conversation

trevnorris
Copy link
Contributor

Now that Buffers instantiate the Uint8Array in JS the error message has
changed in case the allocation fails due to OOM. Tests have been updated
to match.

R=@Fishrock123

@trevnorris
test: fix Buffer OOM error message
ccb022f 
Now that Buffers instantiate the Uint8Array in JS the error message has
changed in case the allocation fails due to OOM. Tests have been updated
to match.
@trevnorris
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/320/

@trevnorris trevnorris added buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests. labels Sep 16, 2015
@Fishrock123 Fishrock123 added build Issues and PRs related to build files or the CI. and removed buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests. labels Sep 16, 2015
@trevnorris trevnorris added buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests. land-on-v4.x and removed build Issues and PRs related to build files or the CI. labels Sep 16, 2015
@Fishrock123 Fishrock123 removed buffer Issues and PRs related to the buffer subsystem. land-on-v4.x test Issues and PRs related to the tests. labels Sep 16, 2015
@Fishrock123
Copy link
Contributor

LGTM if CI is happy

@trevnorris trevnorris added buffer Issues and PRs related to the buffer subsystem. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. land-on-v4.x labels Sep 16, 2015
@Fishrock123 Fishrock123 removed the build Issues and PRs related to build files or the CI. label Sep 16, 2015
@targos
Copy link
Member

targos commented Sep 16, 2015

LGTM

@trevnorris
Copy link
Contributor Author

Thanks all. Landed in 71c53b6.

trevnorris added a commit that referenced this pull request Sep 16, 2015
@trevnorris
test: fix Buffer OOM error message
71c53b6 
Now that Buffers instantiate the Uint8Array in JS the error message has
changed in case the allocation fails due to OOM. Tests have been updated
to match.

PR-URL: #2915
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@trevnorris trevnorris closed this Sep 16, 2015
trevnorris added a commit that referenced this pull request Sep 16, 2015
@trevnorris @Fishrock123
test: fix Buffer OOM error message
079a217 
Now that Buffers instantiate the Uint8Array in JS the error message has
changed in case the allocation fails due to OOM. Tests have been updated
to match.

PR-URL: #2915
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@trevnorris trevnorris deleted the fix-b-test-err-msg branch September 16, 2015 20:38
@rvagg rvagg mentioned this pull request Sep 22, 2015
Merged
@MylesBorins
Copy link
Contributor

landed in lts-v4.x-staging as 079a217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trevnorris @Fishrock123 @targos @MylesBorins @jasnell