stream: read refactor #29155
Closed
stream: read refactor #29155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
ronag
commented
Aug 16, 2019
ronag
force-pushed
the
stream-read-refactor
branch
2 times, most recently
from
f0a46f3 to
463d3fe
Compare
ronag
force-pushed
the
stream-read-refactor
branch
from
463d3fe to
df1756e
Compare
|
@nodejs/streams |
Trott
approved these changes
Aug 19, 2019
|
CITGM shows new-to-me problems in serialport and zeromq but they may be due to the recent V8 update on master or something else? serialport: > core-js@3.2.1 postinstall /home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/citgm_tmp/c3ffcd94-a401-4211-a206-46e0ca1297f6/serialport/node_modules/core-js
> node scripts/postinstall || echo "ignore"
> serialport-monorepo@0.0.0 postinstall /home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/citgm_tmp/c3ffcd94-a401-4211-a206-46e0ca1297f6/serialport
> lerna bootstrap --no-ci
lerna notice cli v3.16.4
lerna info versioning independent
lerna info Bootstrapping 17 packages
lerna info Installing external dependencies
lerna ERR! npm install exited 1 in '@serialport/bindings'
lerna ERR! npm install stdout:
> @serialport/bindings@2.0.8 install /home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/citgm_tmp/c3ffcd94-a401-4211-a206-46e0ca1297f6/serialport/packages/bindings
> node-gyp rebuild
make: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/citgm_tmp/c3ffcd94-a401-4211-a206-46e0ca1297f6/serialport/packages/bindings/build'
CXX(target) Release/obj.target/bindings/src/serialport.o
CXX(target) Release/obj.target/bindings/src/serialport_unix.o
bindings.target.mk:112: recipe for target 'Release/obj.target/bindings/src/serialport.o' failed
make: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/citgm_tmp/c3ffcd94-a401-4211-a206-46e0ca1297f6/serialport/packages/bindings/build'
lerna ERR! npm install stderr:
../src/serialport.cpp: In function void EIO_AfterGet(uv_work_t*):
../src/serialport.cpp:329:96: error: no matching function for call to v8::Object::Set(v8::Local<v8::String>, Nan::imp::FactoryBase<v8::Boolean>::return_t)
results->Set(Nan::New<v8::String>("cts").ToLocalChecked(), Nan::New<v8::Boolean>(data->cts));
^
In file included from /home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/src/node.h:63:0,
from ../node_modules/nan/nan.h:54,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3327:37: note: candidate: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3327:37: note: candidate expects 3 arguments, 2 provided
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3330:37: note: candidate: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, uint32_t, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3330:37: note: candidate expects 3 arguments, 2 provided
../src/serialport.cpp:330:96: error: no matching function for call to v8::Object::Set(v8::Local<v8::String>, Nan::imp::FactoryBase<v8::Boolean>::return_t)
results->Set(Nan::New<v8::String>("dsr").ToLocalChecked(), Nan::New<v8::Boolean>(data->dsr));
^
In file included from /home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/src/node.h:63:0,
from ../node_modules/nan/nan.h:54,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3327:37: note: candidate: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3327:37: note: candidate expects 3 arguments, 2 provided
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3330:37: note: candidate: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, uint32_t, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3330:37: note: candidate expects 3 arguments, 2 provided
../src/serialport.cpp:331:96: error: no matching function for call to v8::Object::Set(v8::Local<v8::String>, Nan::imp::FactoryBase<v8::Boolean>::return_t)
results->Set(Nan::New<v8::String>("dcd").ToLocalChecked(), Nan::New<v8::Boolean>(data->dcd));
^
In file included from /home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/src/node.h:63:0,
from ../node_modules/nan/nan.h:54,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3327:37: note: candidate: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3327:37: note: candidate expects 3 arguments, 2 provided
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3330:37: note: candidate: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, uint32_t, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3330:37: note: candidate expects 3 arguments, 2 provided
../src/serialport.cpp: In function void EIO_AfterGetBaudRate(uv_work_t*):
../src/serialport.cpp:378:106: error: no matching function for call to v8::Object::Set(v8::Local<v8::String>, Nan::imp::IntegerFactory<v8::Integer>::return_t)
results->Set(Nan::New<v8::String>("baudRate").ToLocalChecked(), Nan::New<v8::Integer>(data->baudRate));
^
In file included from /home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/src/node.h:63:0,
from ../node_modules/nan/nan.h:54,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3327:37: note: candidate: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3327:37: note: candidate expects 3 arguments, 2 provided
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3330:37: note: candidate: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, uint32_t, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/node/deps/v8/include/v8.h:3330:37: note: candidate expects 3 arguments, 2 provided
make: *** [Release/obj.target/bindings/src/serialport.o] Error 1
make: *** Waiting for unfinished jobs....
../src/serialport_unix.cpp: In function int setup(int, OpenBaton*):
../src/serialport_unix.cpp:166:5: warning: %s directive output may be truncated writing up to 1023 bytes into a region of size 1005 [-Wformat-truncation=]
int setup(int fd, OpenBaton *data) {
^~~~~
In file included from /usr/include/stdio.h:862:0,
from ../src/serialport.h:3,
from ../src/serialport_unix.cpp:2:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:65:44: note: __builtin___snprintf_chk output 20 or more bytes (assuming 1043) into a destination of size 1024
__bos (__s), __fmt, __va_arg_pack ());
^
../src/serialport_unix.cpp: In function void EIO_Open(uv_work_t*):
../src/serialport_unix.cpp:79:6: warning: %s directive output may be truncated writing up to 1023 bytes into a region of size 1003 [-Wformat-truncation=]
void EIO_Open(uv_work_t* req) {
^~~~~~~~
In file included from /usr/include/stdio.h:862:0,
from ../src/serialport.h:3,
from ../src/serialport_unix.cpp:2:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:65:44: note: __builtin___snprintf_chk output 22 or more bytes (assuming 1045) into a destination of size 1024
__bos (__s), __fmt, __va_arg_pack ());
^
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/smoker/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:196:23)
gyp ERR! stack at ChildProcess.emit (events.js:209:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Linux 4.15.0-39-generic
gyp ERR! command "/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/smoker/bin/node" "/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/smoker/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/citgm_tmp/c3ffcd94-a401-4211-a206-46e0ca1297f6/serialport/packages/bindings
gyp ERR! node -v v13.0.0-pre
gyp ERR! node-gyp -v v5.0.3
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @serialport/bindings@2.0.8 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @serialport/bindings@2.0.8 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/npm_cache/_logs/2019-08-19T14_35_43_300Z-debug.log
lerna ERR! npm install exited 1 in '@serialport/bindings'
lerna WARN complete Waiting for 1 child process to exit. CTRL-C to exit immediately.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! serialport-monorepo@0.0.0 postinstall: `lerna bootstrap --no-ci`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the serialport-monorepo@0.0.0 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/npm_cache/_logs/2019-08-19T14_35_43_471Z-debug.logzeromq: > zeromq@5.1.0 install /home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq
> node scripts/prebuild-install.js || (node scripts/preinstall.js && node-gyp rebuild)
Building libzmq for linux
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether UID '1000' is supported by ustar format... yes
checking whether GID '1000' is supported by ustar format... yes
checking how to create a ustar tar archive... gnutar
checking whether make supports nested variables... (cached) yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking whether C compiler accepts -std=gnu11... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking whether g++ supports C++11 features by default... yes
checking for a sed that does not truncate output... /usr/bin/sed
checking whether to build with code coverage support... no
checking for a sed that does not truncate output... (cached) /usr/bin/sed
checking for gawk... (cached) gawk
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for xmlto... no
checking for asciidoc... no
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... (cached) /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... dlltool
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... no
checking if : is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... no
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... no
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... no
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking for valgrind... no
checking whether the C compiler works... yes
checking whether we are using Intel C compiler... no
checking whether we are using Sun Studio C compiler... no
checking whether we are using clang C compiler... no
checking whether we are using gcc >= 4 C compiler... yes
checking whether the C++ compiler works... yes
checking whether we are using Intel C++ compiler... no
checking whether we are using Sun Studio C++ compiler... no
checking whether we are using clang C++ compiler... no
checking whether we are using gcc >= 4 C++ compiler... yes
checking whether to enable debugging information... no
checking whether to enable code coverage... no
checking if TIPC is available and supports nonblocking connect... no
checking for library containing dladdr... -ldl
checking for pthread_create in -lpthread... yes
checking for clock_gettime in -lrt... yes
checking whether C++ compiler supports -fvisibility=hidden... yes
checking whether C++ compiler supports dso visibility... yes
checking whether to build documentation... no
checking whether to install manpages... no
configure: Choosing polling system from 'kqueue epoll devpoll pollset poll select'...
configure: Using 'epoll' polling system with CLOEXEC
checking for ANSI C header files... (cached) yes
checking errno.h usability... yes
checking errno.h presence... yes
checking for errno.h... yes
checking time.h usability... yes
checking time.h presence... yes
checking for time.h... yes
checking for unistd.h... (cached) yes
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking stddef.h usability... yes
checking stddef.h presence... yes
checking for stddef.h... yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking arpa/inet.h usability... yes
checking arpa/inet.h presence... yes
checking for arpa/inet.h... yes
checking netinet/tcp.h usability... yes
checking netinet/tcp.h presence... yes
checking for netinet/tcp.h... yes
checking netinet/in.h usability... yes
checking netinet/in.h presence... yes
checking for netinet/in.h... yes
checking sys/socket.h usability... yes
checking sys/socket.h presence... yes
checking for sys/socket.h... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking ifaddrs.h usability... yes
checking ifaddrs.h presence... yes
checking for ifaddrs.h... yes
checking sys/uio.h usability... yes
checking sys/uio.h presence... yes
checking for sys/uio.h... yes
checking sys/eventfd.h usability... yes
checking sys/eventfd.h presence... yes
checking for sys/eventfd.h... yes
checking whether EFD_CLOEXEC is supported... yes
checking whether SO_PEERCRED is declared... yes
checking whether LOCAL_PEERCRED is declared... no
checking for stdbool.h that conforms to C99... no
checking for _Bool... no
checking for an ANSI C-conforming const... yes
checking for inline... inline
checking for size_t... yes
checking for ssize_t... yes
checking whether time.h and sys/time.h may both be included... yes
checking for uint32_t... yes
checking for working volatile... yes
configure: Using tweetnacl for CURVE security
checking "with_norm_ext = no"... no
checking how to enable additional warnings for C++ compiler... -Wall
checking how to turn warnings to errors in C++ compiler... -Werror
checking whether compiler supports __atomic_Xxx intrinsics... yes
checking return type of signal handlers... void
checking for perror... yes
checking for gettimeofday... yes
checking for clock_gettime... yes
checking for memset... no
checking for socket... yes
checking for getifaddrs... yes
checking for freeifaddrs... yes
checking for fork... no
checking for posix_memalign... no
checking for mkdtemp... yes
checking alloca.h usability... yes
checking alloca.h presence... yes
checking for alloca.h... yes
checking whether SOCK_CLOEXEC is supported... yes
checking whether SO_KEEPALIVE is supported... yes
checking whether TCP_KEEPCNT is supported... yes
checking whether TCP_KEEPIDLE is supported... yes
checking whether TCP_KEEPINTVL is supported... yes
checking whether TCP_KEEPALIVE is supported... no
checking for ./.git... no
configure: Building stable and legacy API (no draft API)
checking for LIBUNWIND... no
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/libzmq.pc
config.status: creating doc/Makefile
config.status: creating builds/Makefile
config.status: creating builds/msvc/Makefile
config.status: creating src/platform.hpp
config.status: executing depfiles commands
config.status: executing libtool commands
Making all in doc
make[1]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2/doc'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2/doc'
make[1]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2'
CXX src/src_libzmq_la-address.lo
CXX src/src_libzmq_la-client.lo
CXX src/src_libzmq_la-clock.lo
CXX src/src_libzmq_la-ctx.lo
CXX src/src_libzmq_la-curve_client.lo
CXX src/src_libzmq_la-curve_server.lo
CXX src/src_libzmq_la-dealer.lo
CXX src/src_libzmq_la-devpoll.lo
CXX src/src_libzmq_la-dgram.lo
CXX src/src_libzmq_la-dish.lo
CXX src/src_libzmq_la-dist.lo
CXX src/src_libzmq_la-epoll.lo
CXX src/src_libzmq_la-err.lo
CXX src/src_libzmq_la-fq.lo
CXX src/src_libzmq_la-gather.lo
CXX src/src_libzmq_la-gssapi_mechanism_base.lo
CXX src/src_libzmq_la-gssapi_client.lo
CXX src/src_libzmq_la-gssapi_server.lo
CXX src/src_libzmq_la-io_object.lo
CXX src/src_libzmq_la-io_thread.lo
CXX src/src_libzmq_la-ip.lo
CXX src/src_libzmq_la-ipc_address.lo
CXX src/src_libzmq_la-ipc_connecter.lo
CXX src/src_libzmq_la-ipc_listener.lo
CXX src/src_libzmq_la-kqueue.lo
CXX src/src_libzmq_la-lb.lo
CXX src/src_libzmq_la-mailbox.lo
CXX src/src_libzmq_la-mailbox_safe.lo
CXX src/src_libzmq_la-mechanism.lo
CXX src/src_libzmq_la-metadata.lo
CXX src/src_libzmq_la-msg.lo
CXX src/src_libzmq_la-mtrie.lo
CXX src/src_libzmq_la-norm_engine.lo
CXX src/src_libzmq_la-null_mechanism.lo
CXX src/src_libzmq_la-object.lo
CXX src/src_libzmq_la-options.lo
CXX src/src_libzmq_la-own.lo
CXX src/src_libzmq_la-pair.lo
CXX src/src_libzmq_la-pgm_receiver.lo
CXX src/src_libzmq_la-pgm_sender.lo
CXX src/src_libzmq_la-pgm_socket.lo
CXX src/src_libzmq_la-pipe.lo
CXX src/src_libzmq_la-plain_client.lo
CXX src/src_libzmq_la-plain_server.lo
CXX src/src_libzmq_la-poll.lo
CXX src/src_libzmq_la-poller_base.lo
CXX src/src_libzmq_la-pollset.lo
CXX src/src_libzmq_la-precompiled.lo
CXX src/src_libzmq_la-proxy.lo
CXX src/src_libzmq_la-pub.lo
CXX src/src_libzmq_la-pull.lo
CXX src/src_libzmq_la-push.lo
CXX src/src_libzmq_la-radio.lo
CXX src/src_libzmq_la-random.lo
CXX src/src_libzmq_la-raw_decoder.lo
CXX src/src_libzmq_la-raw_encoder.lo
CXX src/src_libzmq_la-reaper.lo
CXX src/src_libzmq_la-rep.lo
CXX src/src_libzmq_la-req.lo
CXX src/src_libzmq_la-router.lo
CXX src/src_libzmq_la-scatter.lo
CXX src/src_libzmq_la-select.lo
CXX src/src_libzmq_la-server.lo
CXX src/src_libzmq_la-session_base.lo
CXX src/src_libzmq_la-signaler.lo
CXX src/src_libzmq_la-socket_base.lo
CXX src/src_libzmq_la-socks.lo
CXX src/src_libzmq_la-socks_connecter.lo
CXX src/src_libzmq_la-stream.lo
CXX src/src_libzmq_la-stream_engine.lo
CXX src/src_libzmq_la-sub.lo
CXX src/src_libzmq_la-tcp.lo
CXX src/src_libzmq_la-tcp_address.lo
CXX src/src_libzmq_la-tcp_connecter.lo
CXX src/src_libzmq_la-tcp_listener.lo
CXX src/src_libzmq_la-thread.lo
CXX src/src_libzmq_la-timers.lo
CXX src/src_libzmq_la-tipc_address.lo
CXX src/src_libzmq_la-tipc_connecter.lo
CXX src/src_libzmq_la-tipc_listener.lo
CXX src/src_libzmq_la-trie.lo
CXX src/src_libzmq_la-udp_address.lo
CXX src/src_libzmq_la-udp_engine.lo
CXX src/src_libzmq_la-v1_decoder.lo
CXX src/src_libzmq_la-v2_decoder.lo
CXX src/src_libzmq_la-v1_encoder.lo
CXX src/src_libzmq_la-v2_encoder.lo
CXX src/src_libzmq_la-vmci.lo
CXX src/src_libzmq_la-vmci_address.lo
CXX src/src_libzmq_la-vmci_connecter.lo
CXX src/src_libzmq_la-vmci_listener.lo
CXX src/src_libzmq_la-xpub.lo
CXX src/src_libzmq_la-xsub.lo
CXX src/src_libzmq_la-zmq.lo
CXX src/src_libzmq_la-zmq_utils.lo
CXX src/src_libzmq_la-decoder_allocators.lo
CXX src/src_libzmq_la-socket_poller.lo
CC src/src_libzmq_la-tweetnacl.lo
CXX tools/curve_keygen.o
CXX perf/local_lat.o
CXX perf/remote_lat.o
CXX perf/local_thr.o
CXX perf/inproc_lat.o
CXX perf/remote_thr.o
CXX perf/inproc_thr.o
CXXLD src/libzmq.la
CXXLD tools/curve_keygen
CXXLD perf/local_lat
CXXLD perf/local_thr
CXXLD perf/remote_lat
CXXLD perf/remote_thr
CXXLD perf/inproc_lat
CXXLD perf/inproc_thr
make[1]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2'
Making install in doc
make[1]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2/doc'
make[2]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2/doc'
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2/doc'
make[1]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2/doc'
make[1]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2'
make[2]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2'
/usr/bin/mkdir -p '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/lib'
/bin/sh ./libtool --mode=install /usr/bin/install -c src/libzmq.la '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/lib'
libtool: install: /usr/bin/install -c src/.libs/libzmq.lai /home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/lib/libzmq.la
libtool: install: /usr/bin/install -c src/.libs/libzmq.a /home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/lib/libzmq.a
libtool: install: chmod 644 /home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/lib/libzmq.a
libtool: install: ranlib /home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/lib/libzmq.a
libtool: finish: PATH="/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/smoker/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/node_modules/.bin:/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/smoker/bin:/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/smoker/lib/node_modules/npm/bin/node-gyp-bin:/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/smoker/lib/node_modules/citgm/node_modules/.bin:/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/smoker/lib/node_modules/citgm/lib/package-manager/node_modules/.bin:/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/smoker/lib/node_modules/.bin:/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/smoker/bin:/home/iojs/nghttp2/src:/home/iojs/wrk:/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/sbin" ldconfig -n /home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/lib
----------------------------------------------------------------------
Libraries have been installed in:
/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/lib
If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
- add LIBDIR to the `LD_LIBRARY_PATH' environment variable
during execution
- add LIBDIR to the `LD_RUN_PATH' environment variable
during linking
- use the `-Wl,-rpath -Wl,LIBDIR' linker flag
- have your system administrator add LIBDIR to `/etc/ld.so.conf'
See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------
/usr/bin/mkdir -p '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/bin'
/bin/sh ./libtool --mode=install /usr/bin/install -c tools/curve_keygen '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/bin'
libtool: install: /usr/bin/install -c tools/curve_keygen /home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/bin/curve_keygen
/usr/bin/mkdir -p '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/include'
/usr/bin/install -c -m 644 include/zmq.h include/zmq_utils.h '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/include'
/usr/bin/mkdir -p '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/lib/pkgconfig'
/usr/bin/install -c -m 644 src/libzmq.pc '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/scripts/../zmq/lib/pkgconfig'
make[2]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2'
make[1]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/zmq/zeromq-4.2.2'
Succesfully build libzmq on Mon Aug 19 2019 15:24:16 GMT+0000 (Coordinated Universal Time)
make: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/build'
CXX(target) Release/obj.target/zmq/binding.o
make: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq/build'
configure: WARNING: Cannot find libunwind
../binding.cc: In member function void zmq::Socket::NotifyReadReady():
../binding.cc:399:73: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated [-Wdeprecated-declarations]
Nan::MakeCallback(this->handle(), callback_v.As<Function>(), 0, NULL);
^
In file included from ../binding.cc:40:0:
../node_modules/nan/nan.h:1024:46: note: declared here
NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback(
^~~~~~~~~~~~
../binding.cc: In member function void zmq::Socket::NotifySendReady():
../binding.cc:407:73: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated [-Wdeprecated-declarations]
Nan::MakeCallback(this->handle(), callback_v.As<Function>(), 0, NULL);
^
In file included from ../binding.cc:40:0:
../node_modules/nan/nan.h:1024:46: note: declared here
NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback(
^~~~~~~~~~~~
../binding.cc: In member function void zmq::Socket::MonitorEvent(uint16_t, int32_t, char*):
../binding.cc:458:73: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated [-Wdeprecated-declarations]
Nan::MakeCallback(this->handle(), callback_v.As<Function>(), 4, argv);
^
In file included from ../binding.cc:40:0:
../node_modules/nan/nan.h:1024:46: note: declared here
NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback(
^~~~~~~~~~~~
../binding.cc: In member function void zmq::Socket::MonitorError(const char*):
../binding.cc:473:73: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated [-Wdeprecated-declarations]
Nan::MakeCallback(this->handle(), callback_v.As<Function>(), 1, argv);
^
In file included from ../binding.cc:40:0:
../node_modules/nan/nan.h:1024:46: note: declared here
NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback(
^~~~~~~~~~~~
../binding.cc: In static member function static void zmq::Socket::UV_BindAsyncAfter(uv_work_t*):
../binding.cc:814:70: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated [-Wdeprecated-declarations]
Nan::MakeCallback(Nan::GetCurrentContext()->Global(), cb, 1, argv);
^
In file included from ../binding.cc:40:0:
../node_modules/nan/nan.h:1024:46: note: declared here
NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback(
^~~~~~~~~~~~
../binding.cc: In static member function static void zmq::Socket::UV_UnbindAsyncAfter(uv_work_t*):
../binding.cc:893:70: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated [-Wdeprecated-declarations]
Nan::MakeCallback(Nan::GetCurrentContext()->Global(), cb, 1, argv);
^
In file included from ../binding.cc:40:0:
../node_modules/nan/nan.h:1024:46: note: declared here
NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback(
^~~~~~~~~~~~
../binding.cc: In static member function static Nan::NAN_METHOD_RETURN_TYPE zmq::Socket::Sendv(Nan::NAN_METHOD_ARGS_TYPE):
../binding.cc:1300:39: error: no matching function for call to v8::Array::Get(uint32_t&)
Local<Object> buf = batch->Get(i).As<Object>();
^
In file included from ../binding.cc:24:0:
/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/node/deps/v8/include/v8.h:3374:43: note: candidate: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/node/deps/v8/include/v8.h:3374:43: note: candidate expects 2 arguments, 1 provided
/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/node/deps/v8/include/v8.h:3377:43: note: candidate: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, uint32_t)
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/node/deps/v8/include/v8.h:3377:43: note: candidate expects 2 arguments, 1 provided
../binding.cc:1300:50: error: expected primary-expression before > token
Local<Object> buf = batch->Get(i).As<Object>();
^
../binding.cc:1300:52: error: expected primary-expression before ) token
Local<Object> buf = batch->Get(i).As<Object>();
^
../binding.cc:1301:48: error: no matching function for call to v8::Array::Get(uint32_t)
Local<Number> flagsObj = batch->Get(i + 1).As<Number>();
^
In file included from ../binding.cc:24:0:
/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/node/deps/v8/include/v8.h:3374:43: note: candidate: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/node/deps/v8/include/v8.h:3374:43: note: candidate expects 2 arguments, 1 provided
/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/node/deps/v8/include/v8.h:3377:43: note: candidate: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, uint32_t)
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
^~~
/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/node/deps/v8/include/v8.h:3377:43: note: candidate expects 2 arguments, 1 provided
../binding.cc:1301:59: error: expected primary-expression before > token
Local<Number> flagsObj = batch->Get(i + 1).As<Number>();
^
../binding.cc:1301:61: error: expected primary-expression before ) token
Local<Number> flagsObj = batch->Get(i + 1).As<Number>();
^
make: *** [zmq.target.mk:109: Release/obj.target/zmq/binding.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/smoker/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:196:23)
gyp ERR! stack at ChildProcess.emit (events.js:209:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Linux 4.17.17-100.fc27.x86_64
gyp ERR! command "/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/smoker/bin/node" "/home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/smoker/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/citgm_tmp/9655ebdb-6d2e-46b8-b335-4ceb59e9f60c/zeromq
gyp ERR! node -v v13.0.0-pre
gyp ERR! node-gyp -v v5.0.3
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! zeromq@5.1.0 install: `node scripts/prebuild-install.js || (node scripts/preinstall.js && node-gyp rebuild)`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the zeromq@5.1.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/iojs/build/workspace/citgm-smoker/nodes/fedora-last-latest-x64/npm_cache/_logs/2019-08-19T15_24_18_033Z-debug.logCITGM run on master for comparison: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1967/ (queued) |
|
@Trott: Those do not look related to this? |
Trott
pushed a commit
that referenced
this pull request
Aug 20, 2019
This slightly refactors read by moving side effects out of howMuchToRead(). We don't actually have to set state.needReadable = true; in howMuchToRead() since read handles 0 return as needReadable. PR-URL: #29155 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in ea765eb |
targos
pushed a commit
that referenced
this pull request
Aug 20, 2019
This slightly refactors read by moving side effects out of howMuchToRead(). We don't actually have to set state.needReadable = true; in howMuchToRead() since read handles 0 return as needReadable. PR-URL: #29155 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly refactors
readby moving side effects out ofhowMuchToRead.We don't actually have to set
state.needReadable = true;inhowMuchToReadsincereadhandles0return asneedReadable.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes