Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make --without-snapshot imply --without-node-snapshot #29294

Closed
wants to merge 1 commit into from
Closed

build: make --without-snapshot imply --without-node-snapshot #29294

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Fixes: #29243

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 24, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25214/

@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 27, 2019
danbev pushed a commit that referenced this pull request Aug 27, 2019
@joyeecheung @danbev
build: make --without-snapshot imply --without-node-snapshot
f96f9fb 
PR-URL: #29294
Fixes: #29243
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev
Copy link
Contributor

danbev commented Aug 27, 2019

Landed in f96f9fb.

@danbev danbev closed this Aug 27, 2019
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@joyeecheung @BridgeAR
build: make --without-snapshot imply --without-node-snapshot
17d656f 
PR-URL: #29294
Fixes: #29243
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@joyeecheung @BridgeAR
build: make --without-snapshot imply --without-node-snapshot
6a914ed 
PR-URL: #29294
Fixes: #29243
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

12.9.0 is it a bug?
8 participants
@joyeecheung @nodejs-github-bot @danbev @bnoordhuis @jasnell @addaleax @targos @richardlau