Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove multiple consecutive blank lines #29352

Conversation

nschonni
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 28, 2019
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member Author

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one to add back one line

doc/changelogs/CHANGELOG_IOJS.md Show resolved Hide resolved
@nschonni nschonni force-pushed the doc--remove-multiple-consecutive-blank-lines branch from 95a14a2 to 4da634e Compare August 28, 2019 22:41
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.
@nschonni nschonni force-pushed the doc--remove-multiple-consecutive-blank-lines branch from 4da634e to 954d153 Compare August 29, 2019 13:04
@nschonni
Copy link
Member Author

Rebased to fix merge conflict

@trivikr
Copy link
Member

trivikr commented Aug 30, 2019

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 30, 2019
@Trott
Copy link
Member

Trott commented Aug 31, 2019

Landed in 9a46cfc

@Trott Trott closed this Aug 31, 2019
Trott pushed a commit that referenced this pull request Aug 31, 2019
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: #29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@nschonni nschonni deleted the doc--remove-multiple-consecutive-blank-lines branch August 31, 2019 22:32
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: #29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: #29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@XhmikosR
Copy link
Contributor

XhmikosR commented Sep 4, 2019

Does remark-lint have this rule enabled @nschonni?

@nschonni
Copy link
Member Author

nschonni commented Sep 4, 2019

No, it doesn't look like it right now https://github.com/nodejs/remark-preset-lint-node/blob/master/index.js

@XhmikosR
Copy link
Contributor

XhmikosR commented Sep 4, 2019 via email

@nschonni
Copy link
Member Author

nschonni commented Sep 4, 2019

Good idea, I've submitted a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants