test: fix test-benchmark-net #29359
Closed
test: fix test-benchmark-net #29359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test-benchmark-net to accommodate recent benchmark additions.
Trott
added
fast-track
|
Collaborators, 👍 here to fast-track. (node-daily-master will fail until this fix or similar lands.) |
addaleax
approved these changes
Aug 28, 2019
cjihrig
approved these changes
Aug 28, 2019
Trott
added
the
author ready
|
Landed in 167960f |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 28, 2019
Fix test-benchmark-net to accommodate recent benchmark additions. PR-URL: nodejs#29359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
Fix test-benchmark-net to accommodate recent benchmark additions. PR-URL: #29359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
Fix test-benchmark-net to accommodate recent benchmark additions. PR-URL: #29359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test-benchmark-net to accommodate recent benchmark additions.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes