Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add encodeInto to TextEncoder #29524

Closed
wants to merge 3 commits into from
Closed

util: add encodeInto to TextEncoder #29524

wants to merge 3 commits into from

Conversation

addaleax
Copy link
Member

Continuation of @AtticusYang’s #28862

Add function encodeInto to TextEncoder, and add MessageChannel
to the encodeInto.any.js test.

Fixes: #28851
Fixes: #26904
Refs: #28862

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
util: add encodeInto to TextEncoder
01698e6 
Add function encodeInto to TextEncoder, and add MessageChannel
to the encodeInto.any.js test.

Fixes: nodejs#28851
Fixes: nodejs#26904
Refs: nodejs#28862
Co-authored-by: AtticusYang <yyongtai@163.com>
@addaleax addaleax added the encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. label Sep 10, 2019
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Sep 10, 2019
devnexen
devnexen approved these changes Sep 11, 2019
View reviewed changes
src/node_buffer.cc Outdated Show resolved Hide resolved
joyeecheung
joyeecheung approved these changes Sep 11, 2019
View reviewed changes
test/wpt/status/encoding.json Outdated Show resolved Hide resolved
@AtticusYang
Copy link

coooool

@jasnell jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 11, 2019
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 11, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25430/

Trott
Trott reviewed Sep 13, 2019
View reviewed changes
doc/api/util.md Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25470/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25476/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25478/

addaleax added a commit that referenced this pull request Sep 13, 2019
@addaleax
util: add encodeInto to TextEncoder
7c9ee6d 
Add function encodeInto to TextEncoder, and add MessageChannel
to the encodeInto.any.js test.

Fixes: #28851
Fixes: #26904
Refs: #28862
Co-authored-by: AtticusYang <yyongtai@163.com>

PR-URL: #29524
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member Author

Landed in 7c9ee6d 🎉

Thanks @AtticusYang for all the work you’ve put into this!

@addaleax addaleax closed this Sep 13, 2019
@addaleax addaleax deleted the encode-into branch September 13, 2019 18:36
targos pushed a commit that referenced this pull request Sep 20, 2019
@addaleax @targos
util: add encodeInto to TextEncoder
11d1ef9 
Add function encodeInto to TextEncoder, and add MessageChannel
to the encodeInto.any.js test.

Fixes: #28851
Fixes: #26904
Refs: #28862
Co-authored-by: AtticusYang <yyongtai@163.com>

PR-URL: #29524
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit that referenced this pull request Sep 24, 2019
@BridgeAR
2019-09-24, Version 12.11.0 (Current)
21e8f36 
Notable changes:

* crypto:
  * Add `oaepLabel` option #29489
* deps:
  * Update V8 to 7.7.299.11 #28918
    * More efficient memory handling
    * Stack trace serialization got faster
    * The `Intl.NumberFormat` API gained new functionality
    * For more information: https://v8.dev/blog/v8-release-77
* events:
  * Add support for `EventTarget` in `once`
    #29498
* fs:
  * Expose memory file mapping flag `UV_FS_O_FILEMAP`
    #29260
* inspector:
  * New API - `Session.connectToMainThread`
    #28870
* process:
  * Initial SourceMap support via `env.NODE_V8_COVERAGE`
    #28960
* stream:
  * Make `_write()` optional when `_writev()` is implemented
    #29639
* tls:
  * Add option to override signature algorithms
    #29598
* util:
  * Add `encodeInto` to `TextEncoder`
    #29524
* worker:
  * The `worker_thread` module is now stable
    #29512
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@addaleax @BridgeAR
util: add encodeInto to TextEncoder
772a5e0 
Add function encodeInto to TextEncoder, and add MessageChannel
to the encodeInto.any.js test.

Fixes: #28851
Fixes: #26904
Refs: #28862
Co-authored-by: AtticusYang <yyongtai@163.com>

PR-URL: #29524
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit that referenced this pull request Sep 25, 2019
@BridgeAR
2019-09-24, Version 12.11.0 (Current)
b50c01c 
Notable changes:

* crypto:
  * Add `oaepLabel` option #29489
* deps:
  * Update V8 to 7.7.299.11 #28918
    * More efficient memory handling
    * Stack trace serialization got faster
    * The `Intl.NumberFormat` API gained new functionality
    * For more information: https://v8.dev/blog/v8-release-77
* events:
  * Add support for `EventTarget` in `once`
    #29498
* fs:
  * Expose memory file mapping flag `UV_FS_O_FILEMAP`
    #29260
* inspector:
  * New API - `Session.connectToMainThread`
    #28870
* process:
  * Initial SourceMap support via `env.NODE_V8_COVERAGE`
    #28960
* stream:
  * Make `_write()` optional when `_writev()` is implemented
    #29639
* tls:
  * Add option to override signature algorithms
    #29598
* util:
  * Add `encodeInto` to `TextEncoder`
    #29524
* worker:
  * The `worker_thread` module is now stable
    #29512

PR-URL: #29695
BridgeAR added a commit that referenced this pull request Sep 25, 2019
@BridgeAR
2019-09-24, Version 12.11.0 (Current)
d36b6f8 
Notable changes:

* crypto:
  * Add `oaepLabel` option #29489
* deps:
  * Update V8 to 7.7.299.11 #28918
    * More efficient memory handling
    * Stack trace serialization got faster
    * The `Intl.NumberFormat` API gained new functionality
    * For more information: https://v8.dev/blog/v8-release-77
* events:
  * Add support for `EventTarget` in `once`
    #29498
* fs:
  * Expose memory file mapping flag `UV_FS_O_FILEMAP`
    #29260
* inspector:
  * New API - `Session.connectToMainThread`
    #28870
* process:
  * Initial SourceMap support via `env.NODE_V8_COVERAGE`
    #28960
* stream:
  * Make `_write()` optional when `_writev()` is implemented
    #29639
* tls:
  * Add option to override signature algorithms
    #29598
* util:
  * Add `encodeInto` to `TextEncoder`
    #29524
* worker:
  * The `worker_thread` module is now stable
    #29512

PR-URL: #29695
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@skyclouds2001 skyclouds2001 mentioned this pull request Nov 20, 2024
Closed
@aduh95 aduh95 mentioned this pull request Nov 25, 2024
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 27, 2024
@lpinca
doc: add history entry for textEncoder.encodeInto()
090aa8b 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos pushed a commit that referenced this pull request Dec 2, 2024
@lpinca @targos
doc: add history entry for textEncoder.encodeInto()
96926ce 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
github-actions bot pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: add history entry for textEncoder.encodeInto()
09ce079 
Fixes: nodejs#55938
PR-URL: nodejs#55990
Refs: nodejs#29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: add history entry for textEncoder.encodeInto()
fc3e1f7 
Fixes: nodejs#55938
PR-URL: nodejs#55990
Refs: nodejs#29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: add history entry for textEncoder.encodeInto()
0567011 
Fixes: nodejs#55938
PR-URL: nodejs#55990
Refs: nodejs#29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: add history entry for textEncoder.encodeInto()
5920a2f 
Fixes: nodejs#55938
PR-URL: nodejs#55990
Refs: nodejs#29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: add history entry for textEncoder.encodeInto()
eb6d3e9 
Fixes: nodejs#55938
PR-URL: nodejs#55990
Refs: nodejs#29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: add history entry for textEncoder.encodeInto()
71daf1e 
Fixes: nodejs#55938
PR-URL: nodejs#55990
Refs: nodejs#29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@lpinca @aduh95
doc: add history entry for textEncoder.encodeInto()
d01e4fe 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@lpinca @aduh95
doc: add history entry for textEncoder.encodeInto()
bed31a7 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@lpinca @aduh95
doc: add history entry for textEncoder.encodeInto()
52d5222 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 pushed a commit that referenced this pull request Dec 18, 2024
@lpinca @aduh95
doc: add history entry for textEncoder.encodeInto()
3558a19 
Fixes: #55938
PR-URL: #55990
Refs: #29524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@devnexen devnexen devnexen approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MessageChannel is not defined in encodeInto.any.js Add TextEncoder.prototype.encodeInto
8 participants
@addaleax @AtticusYang @nodejs-github-bot @jasnell @Trott @joyeecheung @devnexen @BethGriggs