Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove the use of util.isFunction #29566

Closed
wants to merge 1 commit into from
Closed

lib: remove the use of util.isFunction #29566

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

see https://nodejs.org/dist/latest-v12.x/docs/api/util.html#util_util_isfunction_object

util.isFunction has deprecated.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the inspector Issues and PRs related to the V8 inspector protocol label Sep 15, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25490/

@shobhitchittora
Copy link
Contributor

shobhitchittora commented Sep 15, 2019 •
edited
Loading

@himself65 Do we have a way to check the coverage and match it against the list of deprecated api? How did you stumble upon this anyways ?

shobhitchittora
shobhitchittora approved these changes Sep 15, 2019
View reviewed changes
Copy link
Contributor

@shobhitchittora shobhitchittora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himself65
Copy link
Member Author

@shobhitchittora I wanted to write something in inspect else but I found the isFunction, then I entered Ctrl + F to search isFunction...

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 15, 2019
@lpinca
Copy link
Member

lpinca commented Sep 17, 2019

This needs a rebase.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25526/

@Trott
Copy link
Member

Trott commented Sep 17, 2019

Rebased and force-pushed to remove commit that had been force-pushed over on master earlier today, and also to remove the merge commit (which CI fails on).

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25528/

@himself65
Copy link
Member Author

himself65 commented Sep 17, 2019 via email

@Trott
Copy link
Member

Trott commented Sep 17, 2019

yeah, i know but recently i have no PC :(

Yeah, no problem, I did it already, I was just documenting that I did that. Restarted tests and if they pass, this is ready to land.

@himself65
Copy link
Member Author

himself65 commented Sep 17, 2019 via email

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25533/

Trott pushed a commit that referenced this pull request Sep 18, 2019
@himself65 @Trott
lib: remove the use of util.isFunction
7fa03b5 
PR-URL: #29566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 18, 2019

Landed in 7fa03b5

@Trott Trott closed this Sep 18, 2019
@himself65 himself65 deleted the isFunction branch September 18, 2019 02:25
targos pushed a commit that referenced this pull request Sep 20, 2019
@himself65 @targos
lib: remove the use of util.isFunction
7e12af0 
PR-URL: #29566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@himself65 @BridgeAR
lib: remove the use of util.isFunction
144aeea 
PR-URL: #29566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@trivikr trivikr trivikr approved these changes

@shobhitchittora shobhitchittora shobhitchittora approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@himself65 @nodejs-github-bot @shobhitchittora @lpinca @Trott @jasnell @targos @cjihrig @trivikr @ZYSzys