Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: runMicrotasks should check before running too #29581

Closed
wants to merge 1 commit into from
Closed

src: runMicrotasks should check before running too #29581

wants to merge 1 commit into from

Conversation

nornagon
Copy link
Contributor

@nornagon nornagon commented Sep 16, 2019 •
edited by codebytere
Loading

This is a continuation of #29434, rewriting the last remaining call to RunMicrotasks.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nornagon
src: runMicrotasks should check before running too
8cda9c2 
This is a continuation of nodejs#29434, rewriting the last remaining call to RunMicrotasks.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 16, 2019
@nornagon
Copy link
Contributor Author

cc @codebytere who wrote the original patch for this.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 16, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25500/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25558/

@nornagon nornagon mentioned this pull request Sep 20, 2019
Merged
6 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25638/

Trott pushed a commit that referenced this pull request Sep 23, 2019
@nornagon @Trott
src: perform check before running in runMicrotasks()
4ef3ccb 
This is a continuation of #29434,
rewriting the last remaining call to RunMicrotasks.

PR-URL: #29581
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Copy link
Member

Trott commented Sep 23, 2019

Landed in 4ef3ccb

@Trott Trott closed this Sep 23, 2019
targos pushed a commit that referenced this pull request Sep 23, 2019
@nornagon @targos
src: perform check before running in runMicrotasks()
8b55ccb 
This is a continuation of #29434,
rewriting the last remaining call to RunMicrotasks.

PR-URL: #29581
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@nornagon @BridgeAR
src: perform check before running in runMicrotasks()
3878e1e 
This is a continuation of #29434,
rewriting the last remaining call to RunMicrotasks.

PR-URL: #29581
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@JungMinu JungMinu JungMinu approved these changes

@devnexen devnexen devnexen approved these changes

@codebytere codebytere codebytere approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nornagon @nodejs-github-bot @Trott @jasnell @codebytere @devnexen @JungMinu @devsnek @BridgeAR