-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: skip/strip %c formatting #29606
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
added
util
Issues and PRs related to the built-in util module.
console
Issues and PRs related to the console subsystem.
labels
Sep 18, 2019
devsnek
force-pushed
the
console-css-skip
branch
from
September 18, 2019 21:27
8621443
to
bed1ec3
Compare
cjihrig
approved these changes
Sep 18, 2019
addaleax
approved these changes
Sep 18, 2019
devsnek
force-pushed
the
console-css-skip
branch
from
September 18, 2019 21:53
b57ec07
to
5d6ed9e
Compare
targos
approved these changes
Sep 18, 2019
BridgeAR
approved these changes
Sep 18, 2019
devsnek
force-pushed
the
console-css-skip
branch
from
September 18, 2019 22:13
5d6ed9e
to
f9108f3
Compare
Fixes: nodejs#29605 Refs: https://console.spec.whatwg.org Co-Authored-By: Anna Henningsen <github@addaleax.net>
devsnek
force-pushed
the
console-css-skip
branch
from
September 18, 2019 22:54
f9108f3
to
d579249
Compare
ZYSzys
approved these changes
Sep 19, 2019
ZYSzys
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 19, 2019
shobhitchittora
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
devnexen
approved these changes
Sep 19, 2019
lpinca
approved these changes
Sep 19, 2019
addaleax
pushed a commit
that referenced
this pull request
Sep 21, 2019
Fixes: #29605 Refs: https://console.spec.whatwg.org PR-URL: #29606 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Landed in 8235ffd |
devsnek
removed
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 21, 2019
targos
pushed a commit
that referenced
this pull request
Sep 23, 2019
Fixes: #29605 Refs: https://console.spec.whatwg.org PR-URL: #29606 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
Fixes: #29605 Refs: https://console.spec.whatwg.org PR-URL: #29606 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29605
Refs: https://console.spec.whatwg.org
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes