Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,win: goto lint only after defining node_exe #29616

Closed
wants to merge 2 commits into from
Closed

build,win: goto lint only after defining node_exe #29616

wants to merge 2 commits into from

Commits on Sep 19, 2019

  1. build,win: goto lint only after defining node_exe 

    When running `vcbuild lint` on a new prompt where vcbuild was not run
before, `%node_exe%` was not defined and `eslint.js`, `lint-js.js`
and `lint-md.js` would be run directly using the program defined in
Windows (usually the Windows Scripting Host or Notepad).

This moves the goto statement to after `%node_exe%` is defined.

Fixes: nodejs#29602
    @joaocgreis
    joaocgreis committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    119794f View commit details
    Browse the repository at this point in the history

  2. fixup! build,win: goto lint only after defining node_exe

    @joaocgreis
    joaocgreis committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    13dbd64 View commit details
    Browse the repository at this point in the history