doc: sync security policy with nodejs.org #29682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Node.js security disclosure policy has diverged between the website and github: - https://nodejs.org/en/security/ - https://github.com/nodejs/node/security/policy The website is more recent and accurate, so sync the content from: - https://github.com/nodejs/nodejs.org/blob/master/locale/en/security.md
|
/to @nodejs/tsc @nodejs/security-wg PTAL |
richardlau
reviewed
Sep 23, 2019
Trott
reviewed
Sep 26, 2019
Trott
reviewed
Sep 26, 2019
|
@Trott OK, I caved to linter pressure and reformatted the markdown. :-) |
sam-github
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 26, 2019
It doesn't matter here, but to keep this file textually identical to the policy in Node.js, the markdown needs to lint clean. See: nodejs/node#29682
|
@nodejs/tsc Actually, a meta-question, can we remove the content of this file and replace it with a link to https://nodejs.org/en/security/? That would mean it no longer needs to be kept in sync. I'm not sure actual content needs to be here, its not machine readable, for example, so just a URL might be sufficient. Thoughts? |
jasnell
approved these changes
Sep 26, 2019
|
I'm good either way @sam-github ... but given GitHub has started to handle these files more directly it's likely better to keep this to avoid the user from having to deal with another layer of indirection. |
Trott
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 27, 2019
* Wrap security so it respects Node.js linter It doesn't matter here, but to keep this file textually identical to the policy in Node.js, the markdown needs to lint clean. See: nodejs/node#29682 * Update locale/en/security.md Co-Authored-By: Richard Lau <riclau@uk.ibm.com> * Update locale/en/security.md Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
lpinca
approved these changes
Sep 27, 2019
Trott
added
the
author ready
|
Landed in dd74b16 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Sep 28, 2019
The Node.js security disclosure policy has diverged between the website and github: - https://nodejs.org/en/security/ - https://github.com/nodejs/node/security/policy The website is more recent and accurate, so sync the content from: - https://github.com/nodejs/nodejs.org/blob/master/locale/en/security.md PR-URL: nodejs#29682 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 1, 2019
The Node.js security disclosure policy has diverged between the website and github: - https://nodejs.org/en/security/ - https://github.com/nodejs/node/security/policy The website is more recent and accurate, so sync the content from: - https://github.com/nodejs/nodejs.org/blob/master/locale/en/security.md PR-URL: #29682 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node.js security disclosure policy has diverged between the website
and github:
The website is more recent and accurate, so sync the content from:
https://github.com/nodejs/nodejs.org/blob/master/locale/en/security.md
documentation is changed or added
commit message follows commit guidelines