Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify pipeline stream cleanup #29738

Closed
wants to merge 3 commits into from
Closed

doc: clarify pipeline stream cleanup #29738

wants to merge 3 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Sep 27, 2019

Clarify what happens during pipeline cleanup.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Sep 27, 2019
@ronag ronag force-pushed the doc-pipeline-cleanup branch 2 times, most recently from 354b1c5 to 6aa91ad Compare September 27, 2019 20:39
ronag
ronag commented Sep 27, 2019
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
@ronag ronag force-pushed the doc-pipeline-cleanup branch 2 times, most recently from 7355c21 to ad56b01 Compare September 27, 2019 20:44
ronag
ronag commented Sep 27, 2019
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
@ronag ronag force-pushed the doc-pipeline-cleanup branch 3 times, most recently from 5c3f714 to 48d5eed Compare September 27, 2019 20:51
ronag
ronag commented Sep 27, 2019
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
@ronag ronag force-pushed the doc-pipeline-cleanup branch 2 times, most recently from 1cb17cc to 1c0215e Compare September 27, 2019 21:06
@ronag ronag force-pushed the doc-pipeline-cleanup branch from 1c0215e to 4eceeba Compare September 27, 2019 21:07
ronag
ronag commented Sep 27, 2019
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Sep 29, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3945/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 29, 2019
@Trott
Copy link
Member

Trott commented Sep 30, 2019

Landed in 1a3bf4f

@Trott Trott closed this Sep 30, 2019
Trott pushed a commit that referenced this pull request Sep 30, 2019
@ronag @Trott
doc: clarify pipeline stream cleanup
1a3bf4f 
PR-URL: #29738
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Oct 1, 2019
@ronag @targos
doc: clarify pipeline stream cleanup
2ea4cc0 
PR-URL: #29738
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Oct 1, 2019
Merged
@beevelop beevelop mentioned this pull request Oct 1, 2019
Closed
@kissofire kissofire mentioned this pull request Feb 25, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Feb 25, 2021
Open
@ron-a20 ron-a20 mentioned this pull request Feb 26, 2021
Open
@sitedata sitedata mentioned this pull request Feb 26, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Feb 26, 2021
Open
@137717unity 137717unity mentioned this pull request Feb 26, 2021
Open
@Rednickle Rednickle mentioned this pull request Feb 26, 2021
Open
This was referenced May 5, 2021
Open
Closed
Closed
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Oct 30, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 30, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Oct 30, 2022
Open
@kissofire kissofire mentioned this pull request Oct 30, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 30, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Oct 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2022
Open
@kissofire kissofire mentioned this pull request Dec 6, 2023
Open
@137717unity 137717unity mentioned this pull request Dec 6, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Dec 6, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 6, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronag @Trott @lpinca @nodejs-github-bot