util: validate formatWithOptions inspectOptions #29824

BridgeAR · 2019-10-03T02:05:14Z

This makes sure that the inspectOptions are validated. This could
otherwise cause confusion.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

This makes sure that the `inspectOptions` are validated. This could otherwise cause confusion. Fixes: nodejs#29726

nodejs-github-bot · 2019-10-03T11:41:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25830/
CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2029/

BridgeAR · 2019-10-09T18:54:25Z

@nodejs/tsc this needs one more LG from the TSC. PTAL

Trott · 2019-10-11T04:35:23Z

CITGM results seem OK. Landing.

Trott · 2019-10-11T04:36:36Z

Landed in 2664dac

This makes sure that the `inspectOptions` are validated. This could otherwise cause confusion. Fixes: #29726 PR-URL: #29824 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Notable changes: - **assert**: - do not repeat .throws() code (Ruben Bridgewater) [#28263](#28263) - wrap validation function errors (Ruben Bridgewater) [#28263](#28263) - fix generatedMessage property (Ruben Bridgewater) [#28263](#28263) - improve class instance errors (Ruben Bridgewater) [#28263](#28263) - **benchmark**: - use test/common/tmpdir consistently (João Reis) [#28858](#28858) - **build**: - make full-icu the default for releases (Richard Lau) [#29887](#29887) - update minimum Xcode version for macOS (Michael Dawson) [#29622](#29622) - **child_process**: - runtime deprecate \_channel (cjihrig) [#27949](#27949) - simplify spawn argument parsing (cjihrig) [#27854](#27854) - **console**: - display timeEnd with suitable time unit (Xavier Stouder) [#29251](#29251) - **deps**: - patch V8 to 7.8.279.14 (Myles Borins) [#29694](#29694) - patch V8 to 7.8.279.12 (Myles Borins) [#29694](#29694) - patch V8 to 7.8.279.10 (Myles Borins) [#29694](#29694) - update V8's postmortem script (cjihrig) [#29694](#29694) - V8: cherry-pick 716875d (Myles Borins) [#29694](#29694) - update V8 to 7.8.279.9 (Myles Borins) [#29694](#29694) - V8: cherry-pick b33af60 (Michaël Zasso) [#28016](#28016) - update V8 to 7.6.303.28 (Michaël Zasso) [#28016](#28016) - **domain**: - error handler runs outside of its domain (Julien Gilli) [#26211](#26211) - **fs**: - make FSWatcher.start private (Lucas Holmquist) [#29905](#29905) - add runtime deprecate for file stream open() (Robert Nagy) [#29061](#29061) - allow int64 offset in fs.write/writeSync/fd.write (Zach Bjornson) [#26572](#26572) - use IsSafeJsInt instead of IsNumber for ftruncate (Zach Bjornson) [#26572](#26572) - allow int64 offset in fs.read/readSync/fd.read (Zach Bjornson) [#26572](#26572) - close file descriptor of promisified truncate (João Reis) [#28858](#28858) - **http**: - do not emit end after aborted (Robert Nagy) [#27984](#27984) - don't emit 'data' after 'error' (Robert Nagy) [#28711](#28711) - remove legacy parser (Anna Henningsen) [#29589](#29589) - throw if 'host' agent header is not a string value (Giorgos Ntemiris) [#29568](#29568) - replace superfluous connection property with getter/setter (Robert Nagy) [#29015](#29015) - fix test where aborted should not be emitted (Robert Nagy) [#20077](#20077) - remove default 'timeout' listener on upgrade (Luigi Pinca) [#26030](#26030) - **http, http2**: - remove default server timeout (Ali Ijaz Sheikh) [#27558](#27558) - **http2**: - remove security revert flags (Anna Henningsen) [#29141](#29141) - remove callback-based padding (Anna Henningsen) [#29144](#29144) - **lib**: - rename validateInteger to validateSafeInteger (Zach Bjornson) [#26572](#26572) - correct error.errno to always be numeric (Joyee Cheung) [#28140](#28140) - no need to strip BOM or shebang for scripts (Refael Ackermann) [#27375](#27375) - rework logic of stripping BOM+Shebang from commonjs (Gus Caplan) [#27768](#27768) - **module**: - runtime deprecate createRequireFromPath() (cjihrig) [#27951](#27951) - **readline**: - error on falsy values for callback (Sam Roberts) [#28109](#28109) - **repl**: - close file descriptor of history file (João Reis) [#28858](#28858) - **src**: - bring 425 status code name into accordance with RFC 8470 (Sergei Osipov) [#29880](#29880) - update NODE\_MODULE\_VERSION to 79 (Myles Borins) [#29694](#29694) - update NODE\_MODULE\_VERSION to 78 (Michaël Zasso) [#28918](#28918) - add error codes to errors thrown in C++ (Yaniv Friedensohn) [#27700](#27700) - use non-deprecated overload of V8::SetFlagsFromString (Michaël Zasso) [#28016](#28016) - update NODE\_MODULE\_VERSION to 77 (Michaël Zasso) [#28016](#28016) - update NODE\_MODULE\_VERSION to 74 (Refael Ackermann) [#27375](#27375) - make process.env.TZ setter clear tz cache (Ben Noordhuis) [#20026](#20026) - enable V8's WASM trap handlers (Gus Caplan) [#27246](#27246) - **stream**: - throw unhandled error for readable with autoDestroy (Robert Nagy) [#29806](#29806) - always invoke callback before emitting error (Robert Nagy) [#29293](#29293) - invoke callback before emitting error always (Robert Nagy) [#29293](#29293) - do not flush destroyed writable (Robert Nagy) [#29028](#29028) - don't emit finish on error (Robert Nagy) [#28979](#28979) - disallow stream methods on finished stream (Robert Nagy) [#28687](#28687) - do not emit after 'error' (Robert Nagy) [#28708](#28708) - fix destroy() behavior (Robert Nagy) [#29058](#29058) - simplify `.pipe()` and `.unpipe()` in Readable (Weijia Wang) [#28583](#28583) - **tools**: - patch V8 to run on older XCode versions (Ujjwal Sharma) [#29694](#29694) - update V8 gypfiles (Michaël Zasso) [#29694](#29694) - support full-icu by default (Steven R. Loomis) [#29522](#29522) - **util**: validate formatWithOptions inspectOptions (Ruben Bridgewater) [#29824](#29824) PR-URL: #29504

util: validate formatWithOptions inspectOptions

41d0be3

This makes sure that the `inspectOptions` are validated. This could otherwise cause confusion. Fixes: nodejs#29726

BridgeAR added util Issues and PRs related to the built-in util module. semver-major PRs that contain breaking changes and should be released in the next major version. labels Oct 3, 2019

ZYSzys approved these changes Oct 3, 2019

View reviewed changes

jasnell added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Oct 3, 2019

jasnell approved these changes Oct 3, 2019

View reviewed changes

JungMinu approved these changes Oct 6, 2019

View reviewed changes

cjihrig approved these changes Oct 9, 2019

View reviewed changes

targos approved these changes Oct 9, 2019

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 9, 2019

Trott closed this Oct 11, 2019

BethGriggs mentioned this pull request Oct 15, 2019

2019-10-22, Version 13.0.0 (Current) #29504

Merged

BridgeAR deleted the validate-format-with-options branch January 20, 2020 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

util: validate formatWithOptions inspectOptions #29824

util: validate formatWithOptions inspectOptions #29824

BridgeAR commented Oct 3, 2019

nodejs-github-bot commented Oct 3, 2019 •

edited by BridgeAR

Loading

BridgeAR commented Oct 9, 2019

Trott commented Oct 11, 2019

Trott commented Oct 11, 2019

util: validate formatWithOptions inspectOptions #29824

util: validate formatWithOptions inspectOptions #29824

Conversation

BridgeAR commented Oct 3, 2019

Checklist

nodejs-github-bot commented Oct 3, 2019 • edited by BridgeAR Loading

BridgeAR commented Oct 9, 2019

Trott commented Oct 11, 2019

Trott commented Oct 11, 2019

nodejs-github-bot commented Oct 3, 2019 •

edited by BridgeAR

Loading