Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm: unflag --experimental-exports #29867

Closed
wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Oct 7, 2019

This removes the experimental --experimental-exports flag to make the support on by default.

This PR should not land until we have:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 7, 2019
@guybedford guybedford mentioned this pull request Oct 7, 2019
14 tasks
@guybedford guybedford added the esm Issues and PRs related to the ECMAScript Modules implementation. label Oct 7, 2019
@guybedford
Copy link
Contributor Author

//cc @nodejs/modules-active-members

@Trott Trott added the wip Issues and PRs that are still a work in progress. label Oct 9, 2019
@Trott
Copy link
Member

Trott commented Oct 9, 2019

Added the WIP label based on the PR description (although feel free to swap it out for the blocked label if that's more appropriate).

@guybedford guybedford removed the wip Issues and PRs that are still a work in progress. label Oct 9, 2019
@guybedford
Copy link
Contributor Author

We got resolution in today's meeting to merge this, with the behaviour still flagged by --experimental-modules, thus making it part of the baseline modules features.

We just need core collaborator approvals to land further.

Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as discussed in the WG meeting.

@nodejs-github-bot
Copy link
Collaborator

@guybedford guybedford added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2019
@guybedford
Copy link
Contributor Author

Can I get a further review here from someone? Would be great to land soon to prepare for #29866.

@Trott

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@guybedford
Copy link
Contributor Author

Thanks @Trott just running a final CI with the latest rebase.

doc/api/cli.md Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Oct 10, 2019

Landed in b798f64

@Trott Trott closed this Oct 10, 2019
Trott pushed a commit that referenced this pull request Oct 10, 2019
PR-URL: #29867
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Nov 8, 2019
PR-URL: #29867
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants