Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: test Python 3.7 on Travis CI AGAIN #29985

Closed
wants to merge 3 commits into from
Closed

build: test Python 3.7 on Travis CI AGAIN #29985

wants to merge 3 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 15, 2019 •
edited
Loading

Reimplement #29451 on the master branch

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cclauss
build: test Python 3.7 on Travis CI AGAIN
3cfa680 
Reimplement #29451 on the master branch
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 15, 2019
richardlau
richardlau reviewed Oct 15, 2019
View reviewed changes
.travis.yml Outdated
# - PYTHON_VERSION="3.7.1"
- PYTHON_VERSION="3.7.1"
- PYTHON=python3
- EXPERIMENTAL_NODE_GYP_PYTHON3="yes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget, is EXPERIMENTAL_NODE_GYP_PYTHON3 still required for node-gyp 5.x?

.travis.yml Outdated
@@ -10,9 +10,11 @@ language: cpp
# To experiment with Python 3, comment out Python 2.7 and uncomment one of the Python 3 versions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind switching the Python on Travis to Python 3 (assuming everything works). If so this comment can go.

@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Oct 15, 2019
@sam-github
Copy link
Contributor

Looked like some travis failures:

pyenv: version `3.8.0' not installed
The command "pyenv global ${PYTHON_VERSION}" exited with 1.

@richardlau richardlau mentioned this pull request Oct 16, 2019
Closed
3 tasks
@cclauss
Copy link
Contributor Author

cclauss commented Oct 17, 2019

Closing in favor of #29451

@cclauss cclauss closed this Oct 17, 2019
@cclauss cclauss deleted the Test-Python3-on-Travis-CI branch October 17, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

@rvagg rvagg Awaiting requested review from rvagg

@Trott Trott Awaiting requested review from Trott

@sam-github sam-github Awaiting requested review from sam-github

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclauss @sam-github @richardlau @nodejs-github-bot