Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use forward declaration instead of include #30159

Closed
wants to merge 1 commit into from
Closed

src: use forward declaration instead of include #30159

wants to merge 1 commit into from

Conversation

fhinkel
Copy link
Member

@fhinkel fhinkel commented Oct 29, 2019

Reduce number of includes in header file to reduce build time.

@fhinkel
src: use forward declaration instead of include
ee00f6e 
Reduce number of includes in header file to reduce build time.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Oct 29, 2019
@addaleax
Copy link
Member

I think this is already covered by #30133?

@fhinkel
Copy link
Member Author

fhinkel commented Oct 29, 2019

I think this is already covered by #30133?

You're right. Somehow I thought that PR doesn't cover stat_watcher. Sorry for the noise.

@fhinkel fhinkel closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhinkel @addaleax @nodejs-github-bot