Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve doc Http2Session:Timeout #30161

Closed
wants to merge 1 commit into from
Closed

doc: improve doc Http2Session:Timeout #30161

wants to merge 1 commit into from

Conversation

dev-script
Copy link
Contributor

@dev-script dev-script commented Oct 29, 2019 •
edited
Loading

Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't expect any arguments.

Fixes: nodejs/help#877

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@dev-script
doc: improve doc Http2Session:Timeout
087ad7f 
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Fixes: nodejs/help#877
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Oct 29, 2019
@gireeshpunathil
Copy link
Member

lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4017/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2019
gireeshpunathil pushed a commit that referenced this pull request Oct 31, 2019
@dev-script @gireeshpunathil
doc: improve doc Http2Session:Timeout
99247e7 
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil
Copy link
Member

landed as 99247e7

targos pushed a commit that referenced this pull request Nov 5, 2019
@dev-script @targos
doc: improve doc Http2Session:Timeout
1499a72 
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@dev-script @targos
doc: improve doc Http2Session:Timeout
cf99a73 
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@dev-script @targos
doc: improve doc Http2Session:Timeout
38cc61a 
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@dev-script @targos
doc: improve doc Http2Session:Timeout
85f6488 
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@dev-script @targos
doc: improve doc Http2Session:Timeout
7b50474 
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@devnexen devnexen devnexen approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document event arguments (http2, maybe more)
7 participants
@dev-script @gireeshpunathil @addaleax @lpinca @devnexen @trivikr @nodejs-github-bot