Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: adds assert doc for strict mode with pointer to strict equality #30486

Closed
wants to merge 3 commits into from
Closed

doc: adds assert doc for strict mode with pointer to strict equality #30486

wants to merge 3 commits into from

Conversation

shobhitchittora
Copy link
Contributor

@shobhitchittora shobhitchittora commented Nov 14, 2019 •
edited
Loading

Adds a note to not confuse strict mode in assert module with JS "use strict" directive.

Refs: #30485

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Nov 14, 2019
BridgeAR
BridgeAR reviewed Nov 14, 2019
View reviewed changes
doc/api/assert.md Outdated Show resolved Hide resolved
doc/api/assert.md Outdated Show resolved Hide resolved
@shobhitchittora
Copy link
Contributor Author

@BridgeAR My bad! Just clicked on re-review. 😛

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26628/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26828/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27118/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27170/

@cjihrig
Copy link
Contributor

cjihrig commented Nov 29, 2019

I killed the CI run since it had been running for over 6 hours. Since this is a doc only PR, it doesn't need a full CI run anyway.

cc: @nodejs/build

addaleax pushed a commit that referenced this pull request Dec 3, 2019
@shobhitchittora @addaleax
doc: adds assert doc for strict mode with pointer to strict equality
dbdad4d 
Refs: #30485

PR-URL: #30486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@addaleax
Copy link
Member

addaleax commented Dec 3, 2019

Landed in dbdad4d

@addaleax addaleax closed this Dec 3, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@shobhitchittora @targos
doc: adds assert doc for strict mode with pointer to strict equality
2c0f1ed 
Refs: #30485

PR-URL: #30486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@shobhitchittora @targos
doc: adds assert doc for strict mode with pointer to strict equality
ffad436 
Refs: #30485

PR-URL: #30486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@shobhitchittora @BethGriggs
doc: adds assert doc for strict mode with pointer to strict equality
420d793 
Refs: #30485

PR-URL: #30486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
@shobhitchittora shobhitchittora mentioned this pull request Apr 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shobhitchittora @nodejs-github-bot @cjihrig @addaleax @lpinca @gireeshpunathil @BridgeAR @trivikr