Fixed a typo in a date for version 13.2.0 #30587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
reviewed
Nov 22, 2019
doc/changelogs/CHANGELOG_V13.md
Outdated
| @@ -33,7 +33,7 @@ | |||
| * [Archive](CHANGELOG_ARCHIVE.md) | |||
|
|
|||
| <a id="13.2.0"></a> | |||
| ## 2019-21-19, Version 13.2.0 (Current), @MylesBorins | |||
| ## 2019-11-21git log --oneline files/you/changed, Version 13.2.0 (Current), @MylesBorins | |||
There was a problem hiding this comment.
Suggested change
| ## 2019-11-21git log --oneline files/you/changed, Version 13.2.0 (Current), @MylesBorins | |
| ## 2019-11-21, Version 13.2.0 (Current), @MylesBorins |
😉
There was a problem hiding this comment.
Sorry, will fix, Bad with texts too 🙂
|
collaborators: 👍 to fast-track |
gireeshpunathil
approved these changes
Nov 22, 2019
|
I see that a check fails because it does not see subsystem in the commit message. I've checked other commit messages for this file and they do not have subsystem too. Don't know if I need to do anything about it or not (never committed to node.js before 🙂) |
|
|
kirlat
force-pushed
the
changelog-fix
branch
from
1e8f3b8 to
2929975
Compare
BethGriggs
approved these changes
Nov 22, 2019
addaleax
approved these changes
Nov 22, 2019
|
Landed in f6de66e, thanks for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2019
PR-URL: #30587 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30587 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixed a typo in a date for version 13.2.0. See #30585