Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: backport 93f189f19a03 #30681

Closed
wants to merge 1 commit into from
Closed

deps: V8: backport 93f189f19a03 #30681

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 27, 2019

Original commit message:

[ic] Fix non-GlobalIC store to interceptor on the global object

We possibly need to load the global object from the global proxy as the holder
of the named interceptor.

Change-Id: I0f9f2e448630608ae853588f6751b55574a9efd9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930903
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65119}

Refs: v8/v8@93f189f

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Nov 27, 2019
@targos
Copy link
Member Author

targos commented Nov 27, 2019

Fixes: #30586

@targos
deps: V8: backport 93f189f19a03
95b7da2 
Original commit message:

    [ic] Fix non-GlobalIC store to interceptor on the global object

    We possibly need to load the global object from the global proxy as the holder
    of the named interceptor.

    Change-Id: I0f9f2e448630608ae853588f6751b55574a9efd9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930903
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65119}

Refs: v8/v8@93f189f
Fixes: nodejs#30586
@targos targos mentioned this pull request Nov 27, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 27, 2019 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27074/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/2660/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27123/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27144/

targos added a commit that referenced this pull request Nov 29, 2019
@targos
deps: V8: backport 93f189f19a03
b7b39e0 
Original commit message:

    [ic] Fix non-GlobalIC store to interceptor on the global object

    We possibly need to load the global object from the global proxy as the holder
    of the named interceptor.

    Change-Id: I0f9f2e448630608ae853588f6751b55574a9efd9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930903
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65119}

Refs: v8/v8@93f189f
Fixes: #30586

PR-URL: #30681
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos
Copy link
Member Author

targos commented Nov 29, 2019

Landed in b7b39e0

@targos targos closed this Nov 29, 2019
@targos targos deleted the fix-30586 branch November 29, 2019 15:06
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@targos @addaleax
deps: V8: backport 93f189f19a03
456d250 
Original commit message:

    [ic] Fix non-GlobalIC store to interceptor on the global object

    We possibly need to load the global object from the global proxy as the holder
    of the named interceptor.

    Change-Id: I0f9f2e448630608ae853588f6751b55574a9efd9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930903
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65119}

Refs: v8/v8@93f189f
Fixes: #30586

PR-URL: #30681
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Nov 30, 2019
Closed
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@kevin940726 kevin940726 mentioned this pull request Dec 15, 2019
Merged
@targos
Copy link
Member Author

targos commented Jan 13, 2020

depends on #30020 to land on v12.x

@Pwndrian Pwndrian mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @addaleax @cjihrig @BethGriggs