test: increase debugging information in subprocess test #30761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireeshpunathil
approved these changes
Dec 2, 2019
|
thanks @Trott - I have been thinking of a debugging strategy around this without a way out. This looks like a great plan to me. Only theory that can explain the current behavior (not the failure itself, but the missing debug info) is a race condition between child exit and its pipe flush, and this change is going to resolve that. |
cjihrig
approved these changes
Dec 2, 2019
Trott
added
the
author ready
addaleax
approved these changes
Dec 2, 2019
lpinca
approved these changes
Dec 2, 2019
|
Landed in b299860 |
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
Refs: #25988 (comment) PR-URL: #30761 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 13, 2020
Refs: #25988 (comment) PR-URL: #30761 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Refs: #25988 (comment) PR-URL: #30761 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Apr 13, 2021
Open
This was referenced Sep 18, 2021
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #25988 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes