Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve wasi test coverage and simplify tmpdir imports #30770

Merged
merged 2 commits into from
Dec 5, 2019
Merged

test: improve wasi test coverage and simplify tmpdir imports #30770

merged 2 commits into from
Dec 5, 2019

Commits on Dec 5, 2019

  1. test: simplify tmpdir import in wasi tests 

    PR-URL: nodejs#30770
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    cc5c3b5 View commit details
    Browse the repository at this point in the history

  2. test: improve wasi test coverage 

    Add test coverage for options validation in WASI constructor.

PR-URL: nodejs#30770
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    bcd5491 View commit details
    Browse the repository at this point in the history