test: replace deprecated util.debug() calls #3082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
smoketest
test
| @@ -326,7 +326,7 @@ function test_deep_symlink_mix(callback) { | |||
| [fixturesAbsDir + '/nested-index/two/realpath-c', | |||
| '../../../' + common.tmpDirName + '/cycles/root.js'] | |||
| ].forEach(function(t) { | |||
| //common.debug('setting up '+t[0]+' -> '+t[1]); | |||
| //console.error('setting up '+t[0]+' -> '+t[1]); | |||
There was a problem hiding this comment.
I think this line can simply be removed
There was a problem hiding this comment.
@targos I think you're right. Done!
|
LGTM |
Trott
force-pushed
the
rm-common-debug
branch
from
a4e0d08 to
9d2dfac
Compare
common.debug() is just util.debug() and emits a deprecation notice. Per docs, use console.error() instead. PR-URL: nodejs#3083 Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Trott
force-pushed
the
rm-common-debug
branch
from
9d2dfac to
7edf858
Compare
Trott
added a commit
that referenced
this pull request
Sep 28, 2015
common.debug() is just util.debug() and emits a deprecation notice. Per docs, use console.error() instead. PR-URL: #3082 Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
|
Landed in 44efd66 |
Trott
added a commit
that referenced
this pull request
Sep 30, 2015
common.debug() is just util.debug() and emits a deprecation notice. Per docs, use console.error() instead. PR-URL: #3082 Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
This was referenced Sep 30, 2015
Trott
added a commit
that referenced
this pull request
Sep 30, 2015
common.debug() is just util.debug() and emits a deprecation notice. Per docs, use console.error() instead. PR-URL: #3082 Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.debug()is justutil.debug()and emits a deprecation notice. Per docs, useconsole.error()instead.