Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: replace every Symbol.for by SymbolFor #30857

Closed
wants to merge 1 commit into from
Closed

lib: replace every Symbol.for by SymbolFor #30857

wants to merge 1 commit into from

Conversation

Sebastien-Ahkrin
Copy link
Contributor

@Sebastien-Ahkrin Sebastien-Ahkrin commented Dec 8, 2019 •
edited
Loading

Just replacing every Symbol.for by SymbolFor in the lib/* folder

And adding SymbolFor in the import

const {
  // [...]
  SymbolFor,
} = primordials;

This task was given to me by @targos thanks again ❤️
I hope this new PR will help you :x

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 8, 2019
@Sebastien-Ahkrin Sebastien-Ahkrin force-pushed the SymbolFor branch 3 times, most recently from 52470c1 to ebdc308 Compare December 8, 2019 18:12
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27500/

@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27515/

targos pushed a commit that referenced this pull request Dec 11, 2019
@Sebastien-Ahkrin @targos
lib: replace every Symbol.for by SymbolFor primordials
11465d3 
PR-URL: #30857
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos
Copy link
Member

targos commented Dec 11, 2019

Landed in 11465d3

@targos targos closed this Dec 11, 2019
MylesBorins pushed a commit that referenced this pull request Dec 13, 2019
@Sebastien-Ahkrin @MylesBorins
lib: replace every Symbol.for by SymbolFor primordials
39898a9 
PR-URL: #30857
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin @targos
lib: replace every Symbol.for by SymbolFor primordials
54aa3b9 
PR-URL: #30857
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin @BethGriggs
lib: replace every Symbol.for by SymbolFor primordials
993c419 
PR-URL: #30857
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
@Leko Leko mentioned this pull request Oct 1, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sebastien-Ahkrin @nodejs-github-bot @targos @cjihrig @trivikr