Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix missing arch suffix in binary tar name #30877

Closed
wants to merge 1 commit into from
Closed

build: fix missing arch suffix in binary tar name #30877

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 10, 2019
@legendecas legendecas changed the title build: fix missing x64 arch suffix in binary tar name build: fix missing arch suffix in binary tar name Dec 10, 2019
@legendecas
Copy link
Member Author

@nodejs/build wondering if this misaligned endif was made by intention or not, may I ask for reviews on the PR from build team forks?

richardlau
richardlau approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'm assuming the release jobs (I can't see them) have the ARCH environment variable set, which is why this wasn't spotted before or cause issues for the releases.

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27617/

@richardlau
Copy link
Member

cc @nodejs/build-files

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27634/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27646/

Trott pushed a commit that referenced this pull request Dec 14, 2019
@legendecas @Trott
build: fix missing x64 arch suffix in binary tar name
1807c3e 
PR-URL: #30877
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 14, 2019

Landed in 1807c3e

@Trott Trott closed this Dec 14, 2019
@legendecas legendecas deleted the build branch December 14, 2019 05:47
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@legendecas @MylesBorins
build: fix missing x64 arch suffix in binary tar name
60225c1 
PR-URL: #30877
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
Merged
@rvagg
Copy link
Member

rvagg commented Dec 20, 2019

👍

I've been very careful to make sure to be explicit with ARCH (and some others) on release machines which is why this probably hasn't been caught before.

targos pushed a commit that referenced this pull request Jan 14, 2020
@legendecas @targos
build: fix missing x64 arch suffix in binary tar name
1811b1a 
PR-URL: #30877
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@legendecas @BethGriggs
build: fix missing x64 arch suffix in binary tar name
dc7a232 
PR-URL: #30877
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@devnexen devnexen devnexen approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legendecas @nodejs-github-bot @richardlau @Trott @rvagg @devnexen