Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,win: support building MSI with VS2019 #30895

Closed
wants to merge 2 commits into from
Closed

build,win: support building MSI with VS2019 #30895

wants to merge 2 commits into from

Commits on Dec 11, 2019

  1. build,win: support building MSI with VS2019 

    Explicitly pass the WiX SDK directory when building the MSI. WiX
doesn't (yet?) have a directory for VS2019, so use the one for VS2017
which should be compatible.
    @joaocgreis
    joaocgreis committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    fc7b68d View commit details
    Browse the repository at this point in the history

  2. fixup! build,win: support building MSI with VS2019

    @joaocgreis
    joaocgreis committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    5e4cc4c View commit details
    Browse the repository at this point in the history