src: explicitly allocate backing stores for v8 stat buffers #30946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes flaky tests that crashed because the allocations ended up at positions of previously allocated `ArrayBuffer`s that were still in the backing store table. In particular, there was a race condition window between destroying a Worker thread’s `Environment` and destroying its `Isolate` in which the underlying memory was already released but the `ArrayBuffer` was still existent, meaning that new memory could be allocated at the address of the previous `ArrayBuffer`. Refs: nodejs#30782
nodejs-github-bot
added
c++
4 tasks
|
This addresses an issue that currently makes Worker tests flaky on various OSes in CI. Please feel free to 👍 this comment to approve fast-tracking. |
Trott
approved these changes
Dec 13, 2019
cjihrig
approved these changes
Dec 13, 2019
Trott
added
the
author ready
apapirovski
approved these changes
Dec 13, 2019
gabrielschulhof
pushed a commit
that referenced
this pull request
Dec 14, 2019
This fixes flaky tests that crashed because the allocations ended up at positions of previously allocated `ArrayBuffer`s that were still in the backing store table. In particular, there was a race condition window between destroying a Worker thread’s `Environment` and destroying its `Isolate` in which the underlying memory was already released but the `ArrayBuffer` was still existent, meaning that new memory could be allocated at the address of the previous `ArrayBuffer`. Refs: #30782 PR-URL: #30946 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in d06efaf. |
|
Marking as dont-land-on because this fixes an issue with a semver-major PR. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes flaky tests that crashed because the allocations ended
up at positions of previously allocated
ArrayBuffers that werestill in the backing store table. In particular, there was a race
condition window between destroying a Worker thread’s
Environmentand destroying its
Isolatein which the underlying memory wasalready released but the
ArrayBufferwas still existent, meaningthat new memory could be allocated at the address of the previous
ArrayBuffer.Refs: #30782
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes