Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.14.1 proposal #31069

Merged
merged 224 commits into from
Jan 7, 2020
Merged
Changes from 1 commit
Commits
Show all changes
224 commits
Select commit Hold shift + click to select a range
d9e5b72
tools: check-imports using utf-8
cclauss Nov 2, 2019
05290fd
tools: update certdata.txt
Oct 31, 2019
74dd216
crypto: update root certificates
Oct 31, 2019
2994976
v8: inspect unserializable objects
addaleax Oct 29, 2019
c80a4d8
encoding: make TextDecoder handle BOM correctly
addaleax Oct 26, 2019
569f797
src: remove unimplemented method from node.h
addaleax Oct 23, 2019
2e729f2
src: make AtExit() callbacks run in reverse order
addaleax Nov 2, 2019
56b3edc
process: make source map getter resistant against prototype tampering
addaleax Nov 2, 2019
fd16e9f
doc: update examples in writing-tests.md
GaryGSC Oct 25, 2019
3f24a87
v8: mark serdes API as stable
addaleax Nov 3, 2019
5e8b2a8
tools: make doctool work if no internet available
richardlau Nov 2, 2019
f66f28e
doc: move inactive Collaborators to emeriti
Trott Nov 4, 2019
6525142
http,async_hooks: keep resource object alive from socket
addaleax Oct 31, 2019
eb8beb5
src: track no of active JS signal handlers
addaleax Nov 2, 2019
d14d9e8
src: make EndStartedProfilers an exit hook
addaleax Nov 2, 2019
fc9e708
src: make WaitForInspectorDisconnect an exit hook
addaleax Nov 2, 2019
da8ceb9
src: use unique_ptr for InitializeInspector()
addaleax Nov 2, 2019
e1a1244
src: run RunBeforeExitCallbacks as part of EmitBeforeExit
addaleax Nov 2, 2019
fd5fed1
dgram: reset bind state before emitting error
addaleax Nov 1, 2019
3d39be7
dgram: remove listeners on bind error
addaleax Nov 1, 2019
d713e5a
doc: update GOVERNANCE.md
Trott Nov 5, 2019
342031e
test: deflake test-tls-close-notify.js
lpinca Nov 1, 2019
634aac5
tls: refactor tls_wrap.cc
artmaks Nov 6, 2019
b141556
module: fix for empty object in InternalModuleReadJSON
guybedford Nov 5, 2019
d59df36
tls: replace var with let and const
Nov 6, 2019
b0816c2
http: replace vars with lets and consts in lib/_http_agent.js
Nov 6, 2019
d8046fc
src: persist strings that are used multiple times in the environment
bmsdave Nov 6, 2019
eceeed7
https: change var to let in lib/https.js
galinaprokofeva Nov 6, 2019
d7c2911
fs: change var to let
nadinTs Nov 6, 2019
ddbe982
assert: replace var with let in lib/assert.js
PerfectPan Nov 5, 2019
2938fe3
cluster: destruct primordials in lib/internal/cluster/worker.js
peze Nov 4, 2019
58fca40
buffer: change var to let
darky Nov 6, 2019
bcc00e1
lib: change var to let in lib/_stream_duplex.js
vabole Nov 6, 2019
7cf19ab
dns: switch var to const/let
Nov 6, 2019
02f606d
process: add coverage tests for sourceMapFromDataUrl method
Nov 6, 2019
f874aa1
path: replace var with let in lib/path.js
peze Nov 5, 2019
5b42857
test: fix test-benchmark-cluster
Trott Nov 9, 2019
d32cd85
doc,meta: remove wait period for npm pull requests
Trott Nov 8, 2019
fe1296e
doc,meta: allow Travis results for doc/comment changes
Trott Nov 8, 2019
5e2848d
test: mark test-http-dump-req-when-res-ends as flaky on windows
Nov 6, 2019
d148330
test: fix Python unittests in ./test and ./tools
cclauss Nov 8, 2019
3710068
doc: add link to node-code-ide-configs in testing
trivikr Nov 1, 2018
88adad2
stream: increase MAX_HWM
ronag Oct 20, 2019
5727bc3
http: http_incoming rename var to let and const
Nov 6, 2019
1597626
net: replaced vars to lets and consts
alexahdp Nov 6, 2019
5b8c481
http: http_common rename var to let and const
Nov 6, 2019
8725a5c
lib: replaced var to let in lib/v8.js
bmsdave Nov 6, 2019
6fe2c7a
tls: replace var with let
dividead Nov 6, 2019
b8b6f25
doc: fix up N-API doc
mhdawson Nov 4, 2019
aaedc06
test: replace Object.assign with object spread
Nov 6, 2019
17963bb
doc, console: remove non-existant methods from docs
SimonSchick Nov 10, 2019
d2c85f3
doc: add lookup to http.request() options
lpinca Nov 10, 2019
bb7e78a
crypto: fix key requirements in asymmetric cipher
tniessen Nov 4, 2019
0c68515
doc: remove "maintenance is supported by" text in BUILDING.md
Trott Nov 12, 2019
11d0170
doc: remove "multiple variants" from BUILDING.md
Trott Nov 12, 2019
2e0ef36
doc: simplify text in pull-requests.md
Trott Nov 13, 2019
2e6b3be
test: change var to const in parallel/test-stream-transform-final*
khoumani Nov 12, 2019
d979a9d
doc: add entry to url.parse() changes metadata
lpinca Nov 10, 2019
b49e63d
test: deflake test-http-dump-req-when-res-ends.js
lpinca Nov 11, 2019
45e9c31
lib: change var to let in string_decoder
Nov 12, 2019
25c8a13
doc: createRequire can take import.meta.url directly
GeoffreyBooth Nov 15, 2019
f2f4529
url: replace var with let in lib/url.js
xefimx Nov 6, 2019
793d360
doc: update 8.x to 10.x in backporting guide
GaryGSC Nov 14, 2019
bd853cc
lib: replace var with let/const
khoumani Nov 12, 2019
ec49ea7
util: replace var with let
ssncferreira Nov 12, 2019
351ee64
benchmark: use let instead of var in assert
dnlup Nov 12, 2019
0f7281a
tls: change loop var to let
Xavier-Redondo Nov 12, 2019
2e70ad3
doc: replace const / var with let
duncanhealy Nov 12, 2019
cf9da71
test: var to const in test-repl-multiline.js
soulmonk Nov 12, 2019
df1d735
test: changed var to const in test
bassgeta Nov 12, 2019
f0b6a23
test: change var to let
nath1as Nov 12, 2019
3d7882e
src: lib/internal/timers.js var -> let/const
nikolaykrashnikov Nov 6, 2019
4dfcc12
test: improve test-fs-open
artmaks Nov 6, 2019
cc93a37
build: store cache on timed out builds on Travis
richardlau Nov 13, 2019
4b716a6
doc: document timed out Travis CI builds
richardlau Nov 13, 2019
2f4069a
src: enhance feature access `CHECK`s during bootstrap
addaleax Nov 12, 2019
8792147
stream: replace var with let
daern91 Nov 12, 2019
91c6fe4
test: changed var to let in test-repl-editor
jlPhillips-rms Nov 12, 2019
c0d9a54
test: Change from var to const
Nov 12, 2019
cbb2f81
querystring: replace var with let/const
Nov 12, 2019
df2dce0
lib: change var to let in internal/streams
marquicodes Nov 12, 2019
33e0bd6
benchmark: use let instead of var in async_hooks
dnlup Nov 13, 2019
d2e32ab
deps: update nghttp2 to 1.40.0
gengjiawen Nov 15, 2019
ec5fe99
doc: adds NO_COLOR to assert doc page
shobhitchittora Nov 14, 2019
e4a1cff
test: handle undefined default_configuration
codebytere Nov 13, 2019
71e3c48
http: revise _http_server.js
Nov 6, 2019
0797cc7
tools: fix build at non-English windows
pd4d10 Nov 15, 2019
4834a31
lib: change var to let/const in internal/querystring.js
artmaks Nov 6, 2019
0ae1d17
net: destructure primordials
Nov 12, 2019
12d7d64
src: add file name to 'Module did not self-register' error
nornagon Oct 25, 2019
614949d
lib: replace var with let and const in readline.js
VinceOPS Nov 12, 2019
80bfc08
lib: replace var with let
Nov 12, 2019
3fb0f7e
test: clean up http-set-trailers
lundibundi Nov 18, 2019
a836ac1
doc: fix overriding of prefix option
lpinca Nov 17, 2019
768bac5
doc: explain GIT_REMOTE_REF in COLLABORATOR_GUIDE
lundibundi Nov 12, 2019
e10f922
doc: add mention for using promisify on class methods
lundibundi Nov 10, 2019
6da56e9
test: add test for options validation of createServer
ZYSzys Nov 19, 2019
13f65d1
http2: remove duplicated assertIsObject
ZYSzys Nov 19, 2019
574b0f2
domain: rename var to let and const
marystogova Nov 6, 2019
d802393
test: improve assertion message in internet dgram test
Trott Nov 19, 2019
9869aaa
test: use reserved .invalid TLD for invalid address in test
Trott Nov 19, 2019
0d26263
test: move test not requiring internet from internet to parallel
Trott Nov 19, 2019
c1cb639
crypto: remove redundant validateUint32 argument
tniessen Nov 21, 2019
cd5076e
test: refactor test-dgram-multicast-set-interface-lo.js
Nov 18, 2019
8af3311
src: fix signal handler crash on close
codebytere Nov 22, 2019
4a5f00c
test: replace setTimeout with setImmediate in stream test
Trott Nov 20, 2019
59c9592
test: use arrow function for callback in stream test
Trott Nov 20, 2019
0903f67
test: remove string literal as message in strictEqual() in stream test
Trott Nov 20, 2019
8e36901
test: move stream test to parallel
Trott Nov 20, 2019
516bdaf
test: move explanatory comment to expected location in file
Trott Nov 20, 2019
88bca0f
test: add common.mustCall() to stream test
Trott Nov 20, 2019
a621ab8
src,doc: add C++ internals documentation
addaleax Nov 19, 2019
fdfcf68
http: destructure primordials in lib/_http_server.js
artmaks Nov 6, 2019
cc84dbf
repl: change var to let
obelaifa Nov 12, 2019
217cc13
events: improve performance caused by primordials
antimonyGu Nov 19, 2019
7ba8037
fs: cover fs.opendir ERR_INVALID_CALLBACK
darky Nov 6, 2019
b21f46d
readline: change var to let
dnlup Nov 12, 2019
bccef49
http2: replace var with let/const
pc3b3r Nov 12, 2019
984c406
test: switch to object spread in common/benchmark.js
Nov 6, 2019
ff4f236
lib: replace var to let in cli_table.js
Jing19 Nov 12, 2019
21be4b1
net: replaced vars to lets and consts
nath1as Nov 12, 2019
0a068db
test: test cover cases when trace is empty
Nov 6, 2019
daa5932
cluster: replace var by let in shared_handle.js
putxe Nov 12, 2019
7f0e7fd
test: dns utils replace var
ovhemert Nov 12, 2019
0c4bb4a
lib: replace var with let/const
Nov 12, 2019
d077550
test: change var to let in test-trace-events
jonchurch Nov 12, 2019
1a83c65
fs: change var to let
alvarp Nov 12, 2019
68f3dde
http2: core.js replace var with let
DanielSchuech Nov 12, 2019
7eafe8a
lib: change var to let
dktistakis Nov 12, 2019
03e6d0d
lib: replace var with let/const
Driesss Nov 12, 2019
e7f1d57
test: replace var with let in pre_execution.js
Vunovati Nov 12, 2019
78c7118
test: use spread instead of object.assign
19shubham11 Nov 12, 2019
46f698f
test: changed var to let in module-errors
jrizza88 Nov 12, 2019
6974f26
child_process: replace var with const/let in internal/child_process.js
lcamargof Nov 12, 2019
96c0615
lib: changed var to let
obelaifa Nov 12, 2019
d708887
test: use spread instead of Object.assign
dnlup Nov 12, 2019
175b8fe
http: replace var with let
Nov 12, 2019
01da702
test: change object assign to spread object
putxe Nov 12, 2019
7ebafda
doc: add note about debugging worker_threads
lundibundi Nov 22, 2019
9832144
cluster: replace var with let
Nov 12, 2019
e72be52
lib: use let instead of var
edspace Nov 12, 2019
dc786c3
lib: change var to let in stream_base_commons
marquicodes Nov 12, 2019
c4fcd5b
lib: main_thread_only change var to let
matijagaspar Nov 12, 2019
df4dddb
src: replaced var with let
Nov 12, 2019
2e37828
test: code&learn var to let update
Nazaroni Nov 12, 2019
1cfaccd
lib: replace var with let
Nov 12, 2019
bce0880
tools: update ESLint to 6.7.1
cjihrig Nov 22, 2019
df91d5f
tools: enable more eslint rules
cjihrig Nov 22, 2019
0d6fbe8
doc: add note of caution about non-conforming streams
ronag Oct 9, 2019
a493feb
doc: document "Resume Build" limitation
richardlau Nov 22, 2019
1c9ba2c
test: test for minimum ICU version consistency
richardlau Nov 23, 2019
e52237d
test: use useful message argument in test function
Trott Nov 24, 2019
7d0631a
lib: adding perf notes js_stream_socket.js
ryanj Nov 12, 2019
2f8dcef
test: change object assign by spread operator
putxe Nov 12, 2019
cb3e008
http2: change var to let compact.js
MariaEmma Nov 12, 2019
a6625dd
lib: replace var with let/const
Tijl5 Nov 12, 2019
8d3e023
child_process: replace var with let/const
dnlup Nov 12, 2019
db02965
process: replace vars in per_thread.js
EmaSuriano Nov 12, 2019
f963409
lib: replace var w/ let
IAmEddieDean Nov 12, 2019
d70ec60
cluster: replace vars in child.js
EmaSuriano Nov 12, 2019
956207f
process: replace var with let/const
deadbeef84 Nov 12, 2019
7421cc8
util: use let instead of var for util/inspect.js
lmammino Nov 12, 2019
d951209
lib: replace var with let/const
jens-cappelle Nov 12, 2019
d138e2d
lib: use let instead of var
19shubham11 Nov 12, 2019
c705a8e
doc: add explanation why keep var with for loop
lrecknagel Nov 12, 2019
12ef7d9
test: dir class initialisation w/o handler
Nov 6, 2019
825b305
test: move test-worker-prof to sequential
Trott Nov 24, 2019
16a8daa
doc: update AUTHORS list
devsnek Nov 26, 2019
8b60065
doc: add 13 and 12 to previous versions
andrewhughes101 Nov 22, 2019
2532bf3
doc: minor updates to releases.md
BethGriggs Nov 25, 2019
bea2069
doc: remove "this API is unstable" note for v8 serdes API
bruce-one Nov 24, 2019
0e68f55
tty: truecolor check moved before 256 check
duncanhealy Nov 13, 2019
4d396fd
n-api: add missed nullptr check in napi_has_own_property
lundibundi Nov 24, 2019
f5ac4ec
test: add regression test for signal handler removal in exit
addaleax Nov 22, 2019
c3ad977
test: add mustCall() to test-inspector-contexts
Trott Nov 26, 2019
ece08a5
test: check for session.post() errors in test-insepctor-context
Trott Nov 26, 2019
196e08d
test: remove destructuring from test-inspector-contexts
Trott Nov 26, 2019
648318d
test: add logging in case of infinite loop
Trott Nov 26, 2019
f6360c1
src,doc: fix broken links
cjihrig Nov 26, 2019
3bb085d
src: cleanup unused headers
alferpal Nov 7, 2019
55e94cb
inspector: properly shut down uv_async_t
addaleax Nov 19, 2019
43cec65
tls: allow empty subject even with altNames defined
jasonmacgowan Sep 17, 2018
d378594
test: remove unused function argument from http test
Trott Nov 26, 2019
564e477
test: do not skip test-http-server-consumed-timeout
Trott Nov 26, 2019
d3bac60
test: remove unnecessary common.platformTimeout() call
Trott Nov 26, 2019
8554ff2
test: move test-https-server-consumed-timeout to parallel
Trott Nov 26, 2019
7589486
deps: update llhttp to 2.0.1
indutny Nov 20, 2019
6b380cc
http: set socket.server unconditionally
addaleax Nov 20, 2019
f9f3ab2
child_process: document kill() return value
cjihrig Nov 26, 2019
6fc562c
doc: revise socket.connect() note
Trott Nov 27, 2019
670e4b5
doc: address nits for src/README.md
addaleax Nov 28, 2019
42cb92f
doc: add missing 'added' versions to module.builtinModules
watson Nov 20, 2019
dc9c770
n-api: detach external ArrayBuffers on env exit
addaleax Nov 19, 2019
646b81c
test: port worker + buffer test to N-API
addaleax Nov 19, 2019
ded0748
dns: use length for building TXT string
addaleax Nov 27, 2019
719e33f
buffer: fix 6-byte writeUIntBE() range check
mscdex Nov 13, 2019
9f49b97
test:refactor createHook test
JenyMzo Nov 20, 2019
4b1f730
src: remove unused variable in node_dir.cc
gengjiawen Nov 5, 2019
9fd6b5e
http2: fix session memory accounting after pausing
Nov 27, 2019
efbe0a2
doc: documenting a bit more FreeBSD case
devnexen Nov 8, 2019
ca96061
doc: fixed a typo in process.md
Nov 6, 2019
7bc8c85
doc: clarify IncomingMessage.destroy() description
XMB5 Nov 4, 2019
da1e5ae
tools: add unified plugin changing links for html docs
Oct 12, 2019
5334f59
doc: note that buf.buffer's contents might differ
strugee Sep 22, 2019
da0c673
benchmark,doc,lib,test: prepare for padding lint rule
Trott Nov 28, 2019
a715c25
tools: enforce blank line between functions
Trott Nov 28, 2019
e624bb5
test: increase coverage for trace_events.js
Trott Nov 28, 2019
ce6a865
stream: improve performance for sync write finishes
addaleax Nov 29, 2019
276741a
test: remove unused callback argument
Trott Nov 29, 2019
5bb7bf3
test: simplify forEach() usage
Trott Nov 29, 2019
b37609d
test: remove unused callback argument
Trott Nov 29, 2019
2afe757
doc: update socket.bufferSize text
Trott Nov 30, 2019
0e76b75
doc: update README.md to fix active/maint times
mhdawson Nov 28, 2019
a8b004b
doc: update signature algorithm in release doc
MylesBorins Nov 26, 2019
616927f
doc: revise REPL uncaught exception text
Trott Nov 30, 2019
295b9d0
test: fix test-benchmark-streams
Trott Dec 2, 2019
5414047
test: use arrow functions in async-hooks tests
GaryGSC Oct 26, 2019
cef6c48
doc: fix typographical error
Trott Nov 30, 2019
dc52988
build,win: propagate error codes in vcbuild
joaocgreis Nov 30, 2019
6105a41
test: add an indicator `isIBMi`
dmabupt Nov 29, 2019
ca878f7
test: add coverage for ERR_TLS_INVALID_PROTOCOL_VERSION
Trott Nov 30, 2019
49c6c37
test: skip test-domain-error-types in debug mode temporariliy
Trott Nov 24, 2019
b08601b
util: fix inspection of errors with tampered name or stack property
BridgeAR Nov 21, 2019
9622fed
2020-01-07, Version 12.14.1 'Erbium' (LTS)
BethGriggs Dec 9, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: add note of caution about non-conforming streams
PR-URL: #29895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
ronag authored and MylesBorins committed Dec 17, 2019
commit 0d6fbe8b30eb83aee829b582fad8ca2993e1e18d
7 changes: 7 additions & 0 deletions doc/api/stream.md
Original file line number Diff line number Diff line change
@@ -1678,6 +1678,13 @@ of a stream that are intended for use by consumers (as described in the
[API for Stream Consumers][] section). Doing so may lead to adverse side effects
in application code consuming the stream.

Avoid overriding public methods such as `write()`, `end()`, `cork()`,
`uncork()`, `read()` and `destroy()`, or emitting internal events such
as `'error'`, `'data'`, `'end'`, `'finish'` and `'close'` through `.emit()`.
Doing so can break current and future stream invariants leading to behavior
and/or compatibility issues with other streams, stream utilities, and user
expectations.

### Simplified Construction
<!-- YAML
added: v1.2.0