Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update parameters for chmod and chmodsync #31085

Closed
wants to merge 1 commit into from
Closed

docs: update parameters for chmod and chmodsync #31085

wants to merge 1 commit into from

Conversation

santoshyadavdev
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Dec 24, 2019
@gireeshpunathil
Copy link
Member

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4114/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 25, 2019
@santoshyadavdev
Copy link
Contributor Author

Thank you team, I have made the changes in commit message.

@Trott
Copy link
Member

Trott commented Dec 27, 2019

@santoshyadav198613 Can you update the commit message to include a subsystem, a better description in the header, and punctuation in the body? If you just want to copy/paste, here's what I would recommend:

doc: update parameter type for fs.chmod()

The mode parameter of fs.chmod() and fs.chmodSync() can be a string or 
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

@Trott Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 27, 2019
@santoshyadavdev
doc: update parameter type for fs.chmod()
c935580 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.
@Trott
Copy link
Member

Trott commented Dec 27, 2019

doc: update parameter type for fs.chmod()

The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

Never mind. I made the edits myself and pushed it to the branch.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 27, 2019
@santoshyadavdev
Copy link
Contributor Author

doc: update parameter type for fs.chmod()
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

Never mind. I made the edits myself and pushed it to the branch.

Sorry I also pushed the same changes.

@Trott
Copy link
Member

Trott commented Dec 27, 2019

Sorry I also pushed the same changes.

Ha ha! Yeah, no problem. Thanks!

@santoshyadavdev
Copy link
Contributor Author

Sorry I also pushed the same changes.

Ha ha! Yeah, no problem. Thanks!

Thanks, this was my first PR sorry for the trouble.

@Trott
Copy link
Member

Trott commented Dec 27, 2019

Landed in 283e7a4.

Thanks for the contribution! 🎉

@Trott Trott closed this Dec 27, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 27, 2019
@santoshyadavdev @Trott
doc: update parameter type for fs.chmod()
283e7a4 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: nodejs#31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
cjihrig added a commit to cjihrig/node that referenced this pull request Dec 27, 2019
@cjihrig
doc: update parameter type for fsPromises.chmod()
08064f3 
This was overlooked in nodejs#31085.
@cjihrig cjihrig mentioned this pull request Dec 27, 2019
Closed
3 tasks
Trott pushed a commit that referenced this pull request Dec 29, 2019
@cjihrig @Trott
doc: update parameter type for fsPromises.chmod()
ba4d68c 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@santoshyadavdev @BridgeAR
doc: update parameter type for fs.chmod()
4c29a6e 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: #31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@cjihrig @BridgeAR
doc: update parameter type for fsPromises.chmod()
6855788 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@santoshyadavdev @targos
doc: update parameter type for fs.chmod()
671a5b7 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: #31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jan 14, 2020
@cjihrig @targos
doc: update parameter type for fsPromises.chmod()
54cbbae 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@santoshyadavdev @BethGriggs
doc: update parameter type for fs.chmod()
a192afc 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: #31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@cjihrig @BethGriggs
doc: update parameter type for fsPromises.chmod()
13fe137 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@santoshyadavdev @gireeshpunathil @Trott @jasnell @trivikr @nodejs-github-bot