Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add build Github Action #31153

Closed
wants to merge 1 commit into from
Closed

src: add build Github Action #31153

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Jan 2, 2020 •
edited
Loading

Fix #31017

Currently not able to reuse common steps. See https://gh.neting.ccmunity/t5/GitHub-Actions/reusing-sharing-inheriting-steps-between-jobs-declarations/m-p/37849#M3100.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 2, 2020
@gengjiawen gengjiawen added the build Issues and PRs related to build files or the CI. label Jan 2, 2020
@gengjiawen gengjiawen force-pushed the feature/ci branch 2 times, most recently from 42af02d to 291cc89 Compare January 2, 2020 12:40
@gengjiawen gengjiawen mentioned this pull request Jan 2, 2020
Closed
@mscdex
Copy link
Contributor

mscdex commented Jan 2, 2020

s/Aciton/Action/ in commit message

@gengjiawen gengjiawen changed the title src: add build Github Aciton src: add build Github Action Jan 4, 2020
@gengjiawen
Copy link
Member Author

cc @nodejs/build

cclauss
cclauss reviewed Jan 8, 2020
View reviewed changes
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@gengjiawen gengjiawen requested a review from cclauss January 8, 2020 15:23
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28316/

@gengjiawen gengjiawen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28319/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28324/

gengjiawen added a commit that referenced this pull request Jan 10, 2020
@gengjiawen
src: add build Github Action
60026c7 
PR-URL: #31153
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gengjiawen
Copy link
Member Author

Landed in 60026c7

@gengjiawen gengjiawen closed this Jan 10, 2020
@gengjiawen gengjiawen deleted the feature/ci branch January 10, 2020 01:02
This was referenced Jan 10, 2020
Merged
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@gengjiawen @MylesBorins
src: add build Github Action
60942cc 
PR-URL: #31153
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@gengjiawen @codebytere
src: add build Github Action
ec3dea1 
PR-URL: #31153
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Apr 2, 2020
@gengjiawen @MylesBorins
src: add build Github Action
b408413 
PR-URL: nodejs#31153
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 2, 2020
@gengjiawen @MylesBorins
src: add build Github Action
782f5db 
Backport-PR-URL: #32608
PR-URL: #31153
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau Awaiting requested review from richardlau

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: introduce github actions
6 participants
@gengjiawen @mscdex @nodejs-github-bot @addaleax @cjihrig @cclauss