contextify: use assert instead of if
#3125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was walking through the vm changes and saw this particular `if` check interesting. In case `ctx` is empty it's going to fail later anyways. So, instead of putting an `if` check there; option a - use assert option b - do nothing Considering the developer wanted to make sure `ctx` is not empty, `assert` option looked more convenient.
brendanashworth
added
the
c++
| if (!ctx.IsEmpty()) | ||
| ctx->SetSecurityToken(env->context()->GetSecurityToken()); | ||
|
|
||
| assert(!ctx.IsEmpty()); |
There was a problem hiding this comment.
Can you use CHECK(...) here?
Sure. done. |
bnoordhuis
pushed a commit
that referenced
this pull request
Oct 1, 2015
I was walking through the vm changes and saw this particular `if` check interesting. In case `ctx` is empty it's going to fail later anyways. So, instead of putting an `if` check there; option a - use CHECK option b - do nothing Considering the developer wanted to make sure `ctx` is not empty, `CHECK` option looked more convenient. PR-URL: #3125 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in e83499a, thanks. Tangential aside: I went over the implementation of |
rvagg
pushed a commit
that referenced
this pull request
Oct 2, 2015
I was walking through the vm changes and saw this particular `if` check interesting. In case `ctx` is empty it's going to fail later anyways. So, instead of putting an `if` check there; option a - use CHECK option b - do nothing Considering the developer wanted to make sure `ctx` is not empty, `CHECK` option looked more convenient. PR-URL: #3125 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was walking through the vm changes and saw this particular
ifcheck is interesting. In casectxis empty it's going to fail later anyways.So, instead of putting an
ifcheck there;option a - use assert
option b - do nothing
Considering the developer wanted to make sure
ctxis not empty,assertoption looked more convenient.