Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: simplify errors using ThrowCryptoError #31436

Closed
wants to merge 2 commits into from
Closed

tls: simplify errors using ThrowCryptoError #31436

wants to merge 2 commits into from

Conversation

tniessen
Copy link
Member

Switching to a default message if err == 0 is already implemented in ThrowCryptoError. This should not cause any observable change in behavior.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@tniessen tniessen added the tls Issues and PRs related to the tls subsystem. label Jan 21, 2020
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Jan 21, 2020
@tniessen tniessen added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Jan 21, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28544/

@tniessen tniessen changed the title tls: simplify errors in SetKey tls: simplify errors using ThrowCryptoError Jan 21, 2020
@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 21, 2020
@tniessen
Copy link
Member Author

tniessen commented Jan 23, 2020 •
edited
Loading

Landed in ab6ab9c (was dd6be9fd0eede2219b8932df578e9646049d48ca), thanks for reviewing.

Had to force-push master because the commit message didn't match the PR title anymore, sorry about that.

@tniessen tniessen closed this Jan 23, 2020
@tniessen tniessen deleted the tls-simplify-errors-in-setkey branch January 23, 2020 14:14
tniessen added a commit that referenced this pull request Jan 23, 2020
@tniessen
tls: simplify errors using ThrowCryptoError
ab6ab9c 
PR-URL: #31436
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@tniessen @codebytere
tls: simplify errors using ThrowCryptoError
03aac4e 
PR-URL: #31436
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@tniessen @codebytere
tls: simplify errors using ThrowCryptoError
8c3e6d0 
PR-URL: #31436
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@tniessen @codebytere
tls: simplify errors using ThrowCryptoError
4f177c4 
PR-URL: #31436
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @nodejs-github-bot @bnoordhuis @Trott @addaleax @cjihrig @devnexen