Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: enable FIPS only when configured with it #3153

Closed
wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Oct 1, 2015

Do not rely on OPENSSL_FIPS in node_crypto.cc when building with
shared FIPS-enabled OpenSSL library. Enable FIPS in core only when
configured with --openssl-fips.

Fix: #3077

cc @nodejs/crypto

Do not rely on `OPENSSL_FIPS` in `node_crypto.cc` when building with
shared FIPS-enabled OpenSSL library. Enable FIPS in core only when
configured with `--openssl-fips`.

Fix: nodejs#3077
@indutny indutny mentioned this pull request Oct 1, 2015
@bnoordhuis
Copy link
Member

LGTM

@indutny
Copy link
Member Author

indutny commented Oct 1, 2015

Thanks, @bnoordhuis. I'm going to skip CI run, because we are not testing FIPS mode anyway.

@indutny
Copy link
Member Author

indutny commented Oct 1, 2015

Landed in 9bd26e7

@indutny indutny closed this Oct 1, 2015
@indutny indutny deleted the fix/gh-3077 branch October 1, 2015 21:41
indutny added a commit that referenced this pull request Oct 1, 2015
Do not rely on `OPENSSL_FIPS` in `node_crypto.cc` when building with
shared FIPS-enabled OpenSSL library. Enable FIPS in core only when
configured with `--openssl-fips`.

Fix: #3077
PR-URL: #3153
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg
Copy link
Member

rvagg commented Oct 2, 2015

I'm going to skip CI run, because we are not testing FIPS mode anyway.

@indutny don't discount weird side-effects that you can't predict, like Windows oddities with .gyp files or compiler differences. CI runs are cheap and for this kind of thing you could just look at a few test runs and verify that builds have happened successfully elsewhere to have confidence so you don't even need to wait for the whole thing if you're impatient.

@indutny
Copy link
Member Author

indutny commented Oct 2, 2015

@rvagg ok, I will do it next time if you insist. I just always try to spare the CI, and save some time for other people :)

indutny added a commit that referenced this pull request Oct 2, 2015
Do not rely on `OPENSSL_FIPS` in `node_crypto.cc` when building with
shared FIPS-enabled OpenSSL library. Enable FIPS in core only when
configured with `--openssl-fips`.

Fix: #3077
PR-URL: #3153
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg mentioned this pull request Oct 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants