Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove preview for heap dump utilities #31570

Closed
wants to merge 1 commit into from
Closed

src: remove preview for heap dump utilities #31570

wants to merge 1 commit into from

Commits on Jan 29, 2020

  1. src: remove preview for heap dump utilities 

    At least `createHeapSnapshotStream()` and `triggerHeapSnapshot()`
do have side effects, and more importantly, they should not be
run transparently. Without this, typing e.g. `v8.getHeapSnapshot()`
into the REPL will result in a crash or infinite loop while the REPL
evaluates the expression for a preview.
    @addaleax
    addaleax committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    c482420 View commit details
    Browse the repository at this point in the history