Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-benchmark-http #31686

Merged
merged 1 commit into from
Feb 8, 2020
Merged

test: fix test-benchmark-http #31686

merged 1 commit into from
Feb 8, 2020
+1 −0

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 7, 2020

fe39757 added a setting to a benchmark
which needs to be reflected in the test.

I'd like to fast-track this to fix the node-daily-master CI run. Collaborators, please 👍 here to approve.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 7, 2020
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28999/

@Trott
Copy link
Member Author

Trott commented Feb 7, 2020 •
edited
Loading

Benchmark CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12075/ ✅

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29004/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29015/

@richardlau
Copy link
Member

Did the same change land on all release lines? If so we should make sure this lands on those too. cc @nodejs/releasers

@Trott
test: fix test-benchmark-http
8a14884 
fe39757 added a setting to a benchmark
which needs to be reflected in the test.

PR-URL: nodejs#31686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott Trott merged commit 8a14884 into nodejs:master Feb 8, 2020
@Trott
Copy link
Member Author

Trott commented Feb 8, 2020

Landed in 8a14884

@Trott Trott deleted the fix-bench-test branch February 8, 2020 02:49
@richardlau richardlau mentioned this pull request Feb 8, 2020
Merged
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@Trott @codebytere
test: fix test-benchmark-http
3bcc2da 
fe39757 added a setting to a benchmark
which needs to be reflected in the test.

PR-URL: #31686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
test: fix test-benchmark-http
7670333 
fe39757 added a setting to a benchmark
which needs to be reflected in the test.

PR-URL: #31686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
test: fix test-benchmark-http
76991fb 
fe39757 added a setting to a benchmark
which needs to be reflected in the test.

PR-URL: #31686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
test: fix test-benchmark-http
bdd1133 
fe39757 added a setting to a benchmark
which needs to be reflected in the test.

PR-URL: #31686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @richardlau @addaleax