stream: fix async iterator destroyed error propagation #31700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an edge case where if _destroy calls the error callback later than one tick the iterator would complete early and not propgate the error. PR-URL: nodejs#31314 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
approved these changes
Feb 8, 2020
|
CI: https://ci.nodejs.org/job/node-test-pull-request/29029/ (:white_check_mark:) |
BridgeAR
added
author ready
|
@nodejs/streams |
jasnell
approved these changes
Feb 13, 2020
mcollina
approved these changes
Feb 14, 2020
ronag
added a commit
that referenced
this pull request
Feb 14, 2020
There was an edge case where if _destroy calls the error callback later than one tick the iterator would complete early and not propgate the error. PR-URL: #31314 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #31700 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in d42348bccc0a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: It should now be safe to re-apply d15b8ea which was reverted in 2cd9892 due to a breaking regression which now is resolved through d016b9d
There was an edge case where if _destroy calls the error callback
later than one tick the iterator would complete early and not
propgate the error.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes