Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add known issues test for #31733 #31734

Closed
wants to merge 3 commits into from

Conversation

bnoordhuis
Copy link
Member

Authenticated decryption works for file streams up to 32768 bytes but
not beyond. Other streams and direct decryption are not affected.

Refs: #31733

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 11, 2020
@bnoordhuis
Copy link
Member Author

cc @nodejs/crypto

@jasnell
Copy link
Member

jasnell commented Feb 11, 2020

/cc @mcollina @ronag

@jasnell jasnell added the known limitation Issues that are identified as known limitations. label Feb 11, 2020
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell
Copy link
Member

jasnell commented Feb 11, 2020

@mcollina ... it's possible that this issue is caused by a timing issue in streams.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. fs Issues and PRs related to the fs subsystem / file system. labels Feb 11, 2020
@nodejs-github-bot
Copy link
Collaborator

@mcollina
Copy link
Member

I don't know what can cause this. What's not clear is if this is a regression or not.

@ronag
Copy link
Member

ronag commented Feb 11, 2020

The error comes from cpp land https://github.com/nodejs/node/blob/master/src/node_crypto.cc#L4574.

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 13, 2020
Authenticated decryption works for file streams up to 32768 bytes but
not beyond. Other streams and direct decryption are not affected.

Refs: nodejs#31733
@bnoordhuis bnoordhuis added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2020
@@ -0,0 +1,142 @@
/* eslint-disable node-core/crypto-check */
Copy link
Member

@Trott Trott Feb 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be a bad idea to create a test/known_issues/.eslintrc.yaml and disable the lint rule there, but also probably outside the scope of this PR.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

Landed in 6f94221

@addaleax addaleax closed this Apr 2, 2020
addaleax pushed a commit that referenced this pull request Apr 2, 2020
Authenticated decryption works for file streams up to 32768 bytes but
not beyond. Other streams and direct decryption are not affected.

Refs: #31733

PR-URL: #31734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@mmarchini
Copy link
Contributor

I'm seeing this failing on #32521, not sure if it's flaky or that PR broke something.

BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
Authenticated decryption works for file streams up to 32768 bytes but
not beyond. Other streams and direct decryption are not affected.

Refs: #31733

PR-URL: #31734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
Authenticated decryption works for file streams up to 32768 bytes but
not beyond. Other streams and direct decryption are not affected.

Refs: #31733

PR-URL: #31734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
Authenticated decryption works for file streams up to 32768 bytes but
not beyond. Other streams and direct decryption are not affected.

Refs: #31733

PR-URL: #31734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. fs Issues and PRs related to the fs subsystem / file system. known limitation Issues that are identified as known limitations. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants