Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: add known_issue test for sync callback with error #31756

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions test/known_issues/test-stream-writable-sync-error.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
'use strict';
const common = require('../common');

// Tests for the regression in _stream_writable discussed in
// https://github.com/nodejs/node/pull/31756

// Specifically, when a write callback is invoked synchronously
// with an error, and autoDestroy is not being used, the error
// should still be emitted on nextTick.

const { Writable } = require('stream');

class MyStream extends Writable {
#cb = undefined;

constructor() {
super({ autoDestroy: false });
}

_write(_, __, cb) {
this.#cb = cb;
}

close() {
// Synchronously invoke the callback with an error.
this.#cb(new Error('foo'));
}
}

const stream = new MyStream();

const mustError = common.mustCall(2);

stream.write('test', () => {});

// Both error callbacks should be invoked.

stream.on('error', mustError);

stream.close();

// Without the fix in #31756, the error handler
// added after the call to close will not be invoked.
stream.on('error', mustError);