test: add coverage for FSWatcher exception #32057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@nodejs/testing |
|
@nodejs/fs |
|
This could use a review or two. @nodejs/collaborators |
lpinca
approved these changes
Mar 4, 2020
Trott
added
the
author ready
antsmartian
approved these changes
Mar 5, 2020
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 5, 2020
Remove convenience function for internal assertions. It is only used once. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: nodejs#32057 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 5, 2020
Cover an previously uncovered exception possible in the internal start function for FSWatcher. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: nodejs#32057 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
|
Landed in 757e203...b1d4c13 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2020
Remove convenience function for internal assertions. It is only used once. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #32057 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2020
Cover an previously uncovered exception possible in the internal start function for FSWatcher. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #32057 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
|
@Trott is this applicable to |
This just adds some test coverage and is inessential, so I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover an previously uncovered exception possible in the internal start
function for FSWatcher.
While at it, remove convenience function for internal assertions from testing common module. It is only used once.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes