Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13.x backport] stream: improve writable.write() performance #32169

Closed
wants to merge 1 commit into from
Closed

[v13.x backport] stream: improve writable.write() performance #32169

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 10, 2020 •
edited
Loading

PR-URL: #31624

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag requested a review from MylesBorins March 10, 2020 07:00
@nodejs-github-bot nodejs-github-bot added stream Issues and PRs related to the stream subsystem. v13.x labels Mar 10, 2020
@ronag ronag force-pushed the backport-31624-to-v13.x branch from dffb531 to b2c65e1 Compare March 10, 2020 07:01
@ronag ronag force-pushed the backport-31624-to-v13.x branch 2 times, most recently from a60ec3c to 7e745f9 Compare March 10, 2020 07:03
@ronag ronag force-pushed the backport-31624-to-v13.x branch from 7e745f9 to fa39531 Compare March 10, 2020 07:04
@ronag ronag mentioned this pull request Mar 10, 2020
Closed
7 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29688/

@mscdex @ronag
stream: improve writable.write() performance
1d88182 
PR-URL: nodejs#31624
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Backport-PR-URL: nodejs#32169
@ronag ronag force-pushed the backport-31624-to-v13.x branch from fa39531 to 1d88182 Compare March 10, 2020 12:22
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29691/

@ronag
Copy link
Member Author

ronag commented Mar 10, 2020 •
edited
Loading

If you wonder about the difference with the original commit. This depends on some other commit I can't find and haven't been backported (possibly semver-major due to other changes in that PR?). Though I think it should be fine like this.

MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@mscdex @MylesBorins
stream: improve writable.write() performance
1e05ddf 
Backport-PR-URL: #32169
PR-URL: #31624
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins
Copy link
Contributor

landed in 1e05ddf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronag @nodejs-github-bot @MylesBorins @mscdex