Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13.x] fs: fix writeFile[Sync] for non-seekable files #32172

Closed
wants to merge 1 commit into from
Closed

[v13.x] fs: fix writeFile[Sync] for non-seekable files #32172

wants to merge 1 commit into from

Conversation

mildsunrise
Copy link
Member

Backport of #32006

@mildsunrise
fs: fix writeFile[Sync] for non-seekable files
33ca1a6 
Completely disables the use of positioned writes at
writeFile and writeFileSync, which allows it to work
with non-seekable files.

Fixes: nodejs#31926

PR-URL: nodejs#32006
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. v13.x labels Mar 10, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29695/

MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@mildsunrise @MylesBorins
fs: fix writeFile[Sync] for non-seekable files
1c4f4cc 
Completely disables the use of positioned writes at
writeFile and writeFileSync, which allows it to work
with non-seekable files.

Fixes: #31926

Backport-PR-URL: #32172
PR-URL: #32006
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins
Copy link
Contributor

landed in 1c4f4cc

@mildsunrise mildsunrise deleted the v13.x-writefile-non-seekable branch March 10, 2020 21:17
targos pushed a commit that referenced this pull request Apr 20, 2020
@mildsunrise @targos
fs: fix writeFile[Sync] for non-seekable files
0108148 
Completely disables the use of positioned writes at
writeFile and writeFileSync, which allows it to work
with non-seekable files.

Fixes: #31926

Backport-PR-URL: #32172
PR-URL: #32006
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mildsunrise @nodejs-github-bot @MylesBorins