Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: don't emit 'finish' after 'error' #32276

Closed
wants to merge 1 commit into from
Closed

http: don't emit 'finish' after 'error' #32276

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 14, 2020

An edge case could emit 'finish' after 'error'.

Refs: #28710

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem. labels Mar 14, 2020
@ronag ronag force-pushed the http-error-finish branch from ace1aec to c67b545 Compare March 14, 2020 23:55
@ronag ronag removed the stream Issues and PRs related to the stream subsystem. label Mar 14, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29838/

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 16, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29867/

@ronag
Copy link
Member Author

ronag commented Mar 18, 2020

Landed in a9270dc

@ronag ronag closed this Mar 18, 2020
ronag added a commit that referenced this pull request Mar 18, 2020
@ronag
http: don't emit 'finish' after 'error'
a9270dc 
PR-URL: #32276
Refs: #28710
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 19, 2020
@ronag @MylesBorins
http: don't emit 'finish' after 'error'
720a2e2 
PR-URL: #32276
Refs: #28710
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@ronag @MylesBorins
http: don't emit 'finish' after 'error'
ef32069 
PR-URL: #32276
Refs: #28710
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos
Copy link
Member

targos commented Apr 22, 2020

is this safe to land on v12 ?

@ronag
Copy link
Member Author

ronag commented Apr 22, 2020

@targos: I think so.

targos pushed a commit that referenced this pull request Apr 22, 2020
@ronag @targos
http: don't emit 'finish' after 'error'
cf47bb9 
PR-URL: #32276
Refs: #28710
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @targos @jasnell @trivikr