Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: delete BaseObjectWeakPtr data when pointee is gone #32393

Closed
wants to merge 1 commit into from
Closed

src: delete BaseObjectWeakPtr data when pointee is gone #32393

wants to merge 1 commit into from

Commits on Mar 20, 2020

  1. src: delete BaseObjectWeakPtr data when pointee is gone 

    Fix the condition for deleting the underlying data pointed to by
a `BaseObjectWeakPtr`, which erroneously skipped that deletion
when `ptr->get()` was `nullptr`. This fixes a memory leak reported
by some of the tests.

Refs: nodejs#30374 (comment)
    @addaleax
    addaleax committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    e6f450e View commit details
    Browse the repository at this point in the history